-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Improve XML parsing
#8462
Conversation
…apper # Conflicts: # src/test/java/de/tum/in/www1/artemis/localvcci/TestResultXmlParserTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts2, test result and SCA when participating in a programming exercise work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS2 and works as expected 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the exam mode on TS1. Works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again on TS1 with a programming exercise with SCA ✅
Checklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
The processing of result artifacts (test results, sca reports) currently uses some custom XML parsing logic. This can get quite complex and error-prone. It also makes it hard to add new supported formats or to adjust to external changes.
Description
This PR removes the custom parsing logic and instead uses the Jackson object mapper with records.
Steps for Testing
Participate in a Programming exercise as a student. Make sure that test results and SCA feedback are visible and correct.
Exam Mode Testing
same for exam exercises
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
unchanged