Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Properly use translations for course enrollment in breadcrumb navigation #7432

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

bensofficial
Copy link
Member

@bensofficial bensofficial commented Oct 22, 2023

Checklist

General

Client

  • I followed the coding and design guidelines.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

Currently, enroll is shown in the breadcrumb if you want to enroll in a course.

Description

This PR adds the link to the translation so that the correct English or German word is shown.

Steps for Testing

Open the course enrollment page and check the breadcrumb.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

Description Screenshot
Previous breadcrumb text Screenshot 2023-10-22 at 12 24 29
New breadcrumb text Screenshot 2023-10-22 at 12 28 11

Respectively the text was changed for English.

@bensofficial bensofficial requested a review from a team as a code owner October 22, 2023 10:32
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Oct 22, 2023
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code + screenshot lgtm

@egekurt123
Copy link
Contributor

Deployed Build#2 on ts2
Kurseinschreibung german
Kurzeinschreibung english

@bensofficial
Copy link
Member Author

@egekurt123 I cannot reproduce the problem. Please make sure, that you deploy this branch in the latest version. This branch is currently on version 6.6.3 (and not 6.6.2).
Thank you!

Screenshot 2023-10-23 at 06 54 08

@xHadie
Copy link

xHadie commented Oct 23, 2023

Tested on TS3 Legacy
LGTM 👍Changes are visible as you described and translation looks fine in english and german.

@krusche krusche added this to the 6.6.3 milestone Oct 23, 2023
@krusche krusche changed the title Development: Add translation for course enrollment to student breadcrumb General: Add German translation for course enrollment to breadcrumb navigation Oct 23, 2023
@krusche krusche changed the title General: Add German translation for course enrollment to breadcrumb navigation General: Properly use translations for course enrollment in breadcrumb navigation Oct 23, 2023
@krusche krusche merged commit 0d34641 into develop Oct 23, 2023
53 of 56 checks passed
@krusche krusche deleted the fix-course-enrollment-breadcrumb-title branch October 23, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) ready for review ready to merge small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants