Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix flaky ResultListenerIntegrationTest #7326

Merged

Conversation

DominikRemo
Copy link
Contributor

@DominikRemo DominikRemo commented Oct 5, 2023

Checklist

General

Server

Motivation and Context

The tests in ResultListenerIntegrationTest were flaky. The tests' failed against MySQL and Postgres because of many scheduled tasks and slower database access.

Description

The tests are fixed by setting lastScheduledRun in ParticipantScoreScheduleService. Setting the value to Instant.now() prevents the ScheduleService from calculating the scores of results unrelated to this tests (Results created in prior tests). Additionally, the schedule delay has been increased to account for slower database access.

MySQL run without failing ResultListenerIntegrationTest(s):
https://github.com/ls1intum/Artemis/actions/runs/6419281166/job/17428804520?pr=7326

Postgres run without failing ResultListenerIntegrationTest(s):
https://github.com/ls1intum/Artemis/actions/runs/6419281166/job/17428804757?pr=7326

Steps for Testing

Test changes only

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@DominikRemo DominikRemo marked this pull request as ready for review October 5, 2023 14:33
@DominikRemo DominikRemo requested a review from a team as a code owner October 5, 2023 14:33
Copy link
Contributor

@laadvo laadvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky test fix LGTM

@DominikRemo DominikRemo added this to the 6.5.5 milestone Oct 5, 2023
@krusche krusche merged commit 43dbc05 into develop Oct 7, 2023
37 of 41 checks passed
@krusche krusche deleted the development/fix-flaky-ResultListenerIntegrationTest branch October 7, 2023 15:42
@krusche krusche modified the milestones: 6.5.5, 6.6.0 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants