Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add drag-and-drop exercise generation tests #7320

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

milljoniaer
Copy link
Contributor

@milljoniaer milljoniaer commented Oct 4, 2023

Checklist

General

Client

  • I followed the coding and design guidelines.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I documented the TypeScript code using JSDoc style.

Motivation and Context

This PR adds tests for the validation of drag and drop exercises. In #7261 there have been alerts added to improve the UX works. The test of this PR ensure that the user keeps updated if there is input missing.

Steps for Testing

see that all affected tests are passing

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@milljoniaer milljoniaer requested a review from a team as a code owner October 4, 2023 14:37
@github-actions github-actions bot added the tests label Oct 4, 2023
@milljoniaer milljoniaer added client Pull requests that update TypeScript code. (Added Automatically!) small labels Oct 4, 2023
@milljoniaer milljoniaer requested a review from a team October 5, 2023 09:56
laurenzfb
laurenzfb previously approved these changes Oct 9, 2023
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test lgtm

aplr
aplr previously approved these changes Oct 9, 2023
Copy link
Contributor

@aplr aplr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

reschandreas
reschandreas previously approved these changes Oct 9, 2023
Copy link
Contributor

@reschandreas reschandreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

basak-akan
basak-akan previously approved these changes Oct 11, 2023
Copy link
Contributor

@basak-akan basak-akan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test looks good 👍

@github-actions github-actions bot removed the client Pull requests that update TypeScript code. (Added Automatically!) label Oct 13, 2023
aplr
aplr previously approved these changes Oct 13, 2023
reschandreas
reschandreas previously approved these changes Oct 13, 2023
@milljoniaer milljoniaer dismissed stale reviews from reschandreas and aplr via ace2b83 October 13, 2023 08:32
@milljoniaer milljoniaer requested a review from Hialus October 19, 2023 10:00
@github-actions
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@krusche krusche added this to the 6.6.4 milestone Nov 3, 2023
@krusche krusche merged commit accb244 into develop Nov 3, 2023
28 of 30 checks passed
@krusche krusche deleted the chore/add-dnd-exercise-validation-tests branch November 3, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants