Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial groups: Change channel prefix for tutorial-groups #7316

Merged

Conversation

lennart-keller
Copy link
Contributor

@lennart-keller lennart-keller commented Oct 4, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I modified multiple integration tests (Spring) related to the features (with a high test coverage).

Motivation and Context

Automatically generated channels for lecture, exercises and exam have a certain prefix (lecture-, exercise-, exam-). This PR introduces such a prefix for tutorial-group channels.

Description

The automatically generated channel name for tutorial groups is prefixed with tutorgroup-, instead of $. Additionally, the maximum allowed length for the name got increased to 30, which is the same length as for other channels.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Course
  1. Create or edit the global tutorial group configuration of the course: Make sure that "Use Artemis managed Tutorial Group Channels" is enabled
  2. Create a tutorial group
  3. A channel should be created in the form of tutorgroup-title-of-tutorgroup

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

@lennart-keller lennart-keller requested a review from a team as a code owner October 4, 2023 12:11
@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) labels Oct 4, 2023
DominikRemo
DominikRemo previously approved these changes Oct 4, 2023
Copy link
Contributor

@DominikRemo DominikRemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

basak-akan
basak-akan previously approved these changes Oct 4, 2023
Copy link
Contributor

@basak-akan basak-akan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 I have just a small comment.

reschandreas
reschandreas previously approved these changes Oct 4, 2023
Copy link
Contributor

@reschandreas reschandreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works code also lgtm

Copy link
Contributor

@basak-akan basak-akan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comment. Code looks good 👍

Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demonstrated in testing session, code LGTM as well

Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Testing Session.

Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and code look good to me.
But we should definitely unite all these occurrences of 30 and other numbers into some constants in the future!

Copy link
Contributor

@florian-glombik florian-glombik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts1, and the code looks fine, as the magic numbers seem to be present at multiple places right now and should probably be replaced within one dedicated PR

Copy link
Contributor

@reschandreas reschandreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapprove

@krusche krusche changed the title Tutorial Groups: Change channel prefix for tutorial-groups Tutorial groups: Change channel prefix for tutorial-groups Oct 4, 2023
@krusche krusche added this to the 6.6.0 milestone Oct 4, 2023
@krusche krusche merged commit b4acfaa into develop Oct 4, 2023
28 of 31 checks passed
@krusche krusche deleted the improvement/communication/tutor-group-channel-prefix branch October 4, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge server Pull requests that update Java code. (Added Automatically!) small tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants