-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial groups
: Change channel prefix for tutorial-groups
#7316
Tutorial groups
: Change channel prefix for tutorial-groups
#7316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍 I have just a small comment.
...ava/de/tum/in/www1/artemis/service/tutorialgroups/TutorialGroupChannelManagementService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works code also lgtm
2a6174b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my comment. Code looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demonstrated in testing session, code LGTM as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Testing Session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes and code look good to me.
But we should definitely unite all these occurrences of 30
and other numbers into some constants in the future!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts1, and the code looks fine, as the magic numbers seem to be present at multiple places right now and should probably be replaced within one dedicated PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reapprove
Tutorial Groups
: Change channel prefix for tutorial-groupsTutorial groups
: Change channel prefix for tutorial-groups
Checklist
General
Server
Motivation and Context
Automatically generated channels for lecture, exercises and exam have a certain prefix (
lecture-
,exercise-
,exam-
). This PR introduces such a prefix for tutorial-group channels.Description
The automatically generated channel name for tutorial groups is prefixed with
tutorgroup-
, instead of$
. Additionally, the maximum allowed length for the name got increased to 30, which is the same length as for other channels.Steps for Testing
Prerequisites:
tutorgroup-title-of-tutorgroup
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots