Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Update screenshots and the button location in plagiarism checks docs #7306

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Development: Update screenshots and the button location in plagiarism checks docs #7306

merged 6 commits into from
Oct 4, 2023

Conversation

jakubriegel
Copy link
Contributor

@jakubriegel jakubriegel commented Oct 3, 2023 •
edited by MarkusPaulsen
Loading

Checklist

General

Motivation and Context

Some of the screenshots in plagiarism checks documentation and path to one button were outdated. The screenshots also contained test data, which should not be presented in the documentation.

Description

New screenshots are uploaded and new path is typed.

Steps for Testing

Read the docs in changed files or here.

Code Review

  • Code Review 1
  • Code Review 2

@jakubriegel jakubriegel requested a review from krusche October 3, 2023 13:50
@jakubriegel jakubriegel changed the title update screenshots and the button location Development: Update screenshots and the button location in plagiarism checks docs Oct 3, 2023
@jakubriegel jakubriegel marked this pull request as ready for review October 3, 2023 13:50
@jakubriegel jakubriegel requested a review from a team as a code owner October 3, 2023 13:50
MarkusPaulsen
MarkusPaulsen approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@MarkusPaulsen MarkusPaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@MarkusPaulsen MarkusPaulsen added the maintainer-approved The feature maintainer has approved the PR label Oct 4, 2023
dearjasmina
dearjasmina approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@dearjasmina dearjasmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@krusche krusche added this to the 6.5.5 milestone Oct 4, 2023
@krusche krusche merged commit 314a0b4 into develop Oct 4, 2023
17 checks passed
@krusche krusche deleted the plagiarism-docs-update branch October 4, 2023 16:16
@krusche krusche modified the milestones: 6.5.5, 6.6.0 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusPaulsen MarkusPaulsen MarkusPaulsen approved these changes

@Strohgelaender Strohgelaender Strohgelaender approved these changes

@dearjasmina dearjasmina dearjasmina approved these changes

@krusche krusche Awaiting requested review from krusche

Assignees

@jakubriegel jakubriegel

Labels
documentation maintainer-approved The feature maintainer has approved the PR ready for review small
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jakubriegel @dearjasmina @Strohgelaender @MarkusPaulsen @krusche