Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Make developer setup travel friendly with pull policy: if_not_present #7290

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Development: Make developer setup travel friendly with pull policy: if_not_present #7290

merged 2 commits into from
Oct 3, 2023

Conversation

reschandreas
Copy link
Contributor

@reschandreas reschandreas commented Sep 29, 2023 •
edited by jakubriegel
Loading

Checklist

General

Server

Motivation and Context

When working on a train/bus/ or wherever there is a spotty internet connection, starting and stopping the Artemis dev setup is hindered by Docker continuously trying to download images it already has (because pull_policy: always is set). This PR replaces that with if_no_present, meaning the image is only pulled if it's unavailable locally.

Description

Steps for Testing

  1. Run docker compose like always and check if the containers still spin up

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

@reschandreas reschandreas self-assigned this Sep 29, 2023
@reschandreas reschandreas requested a review from a team as a code owner September 29, 2023 07:22
@reschandreas reschandreas force-pushed the development/use_if_not_present_as_pull_policy branch from 7ea56a8 to b8b3b91 Compare September 29, 2023 07:22
@reschandreas reschandreas requested a review from a team September 29, 2023 07:27
jakubriegel
jakubriegel previously approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@jakubriegel jakubriegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍🏻

Pulling and starting containers works for me

Hialus
Hialus requested changes Sep 29, 2023
View reviewed changes
docker/test-server-mysql.yml Outdated Show resolved Hide resolved
docker/test-server-postgresql.yml Outdated Show resolved Hide resolved
@reschandreas reschandreas requested a review from Hialus September 29, 2023 09:30
Hialus
Hialus approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@Hialus Hialus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me now.

@aplr
Copy link
Contributor

aplr commented Sep 29, 2023

Looks good, probably add a note in the docs that people can pull w/ docker compose up --pull ... to force update, if it's not in there

@krusche krusche added this to the 6.5.4 milestone Oct 3, 2023
@krusche krusche merged commit 65087f5 into develop Oct 3, 2023
@krusche krusche deleted the development/use_if_not_present_as_pull_policy branch October 3, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strohgelaender Strohgelaender Strohgelaender approved these changes

@Hialus Hialus Hialus approved these changes

@aplr aplr aplr approved these changes

@jakubriegel jakubriegel Awaiting requested review from jakubriegel

Assignees

@reschandreas reschandreas

Labels
docker ready to merge small
Projects
None yet
Milestone
6.5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@reschandreas @aplr @Hialus @Strohgelaender @jakubriegel @krusche