Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Enable changing working time in exam edit screen #7284

Merged
merged 39 commits into from
Oct 14, 2023

Fix tests

81f2352
Select commit
Loading
Failed to load commit list.
Merged

Exam mode: Enable changing working time in exam edit screen #7284

Fix tests
81f2352
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Teamscale / teamscale-findings required action Oct 14, 2023 in 0s

Teamscale

This pull request would introduce 6 new findings

Details

Teamscale's logo 6 added, 0 in changed code, 6 removed 6 Test Gaps (100%) tested changes: 0|untested changes: 2|untested additions: 4

  • src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#167: Clone with 2 instances of length 12 (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java#300: TODO: probably batch these updates? (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java#193: Violation of method length threshold (source lines of code) of 30: 31 (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#182: Method testUpdateExamWorkingTime_rescheduleProgramming_endDateChanged violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#167: Method testUpdateExam_rescheduleProgramming_endDateChanged violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/exam/ExamIntegrationTest.java#428: Clone with 2 instances of length 12 (view in Teamscale)

Annotations

Check warning on line 167 in src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#L167 

Method `testUpdateExam_rescheduleProgramming_endDateChanged` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Fedit-working-time%3AHEAD&id=181CD872A502149754842DED3EE3EAD6

Check warning on line 184 in src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#L167-L184 

Clone with 2 instances of length 12
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Fedit-working-time%3AHEAD&id=8996ECE8F8784E3D040754274E6FD250

Check warning on line 182 in src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#L182 

Method `testUpdateExamWorkingTime_rescheduleProgramming_endDateChanged` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Fedit-working-time%3AHEAD&id=EF9C2ABE17756F16F0621AB909D77E7F

Check warning on line 243 in src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java#L193-L243 

This method is a bit lengthy [0]. Consider shortening it, e.g. by extracting code blocks into separate methods.

[0] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Fedit-working-time%3AHEAD&id=C1AF4737B08B652EE2DD9A4E4899755D

Check warning on line 300 in src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java#L300 

TODO: probably batch these updates?
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Fedit-working-time%3AHEAD&id=F4AC8E1D0A69DF83039E9004B7EF52E1
View more details on Teamscale