Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Update bamboo build agent version #7274

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Development: Update bamboo build agent version #7274

merged 2 commits into from
Oct 3, 2023

Conversation

florian-glombik
Copy link
Contributor

@florian-glombik florian-glombik commented Sep 27, 2023 •
edited
Loading

Checklist

General

Motivation and Context

Creating programming exercises in my local setup did not work due to a version mismatch of bamboo and bamboo-build-agent.

Description

This PR updates the version of bamboo-build-agent and resolves the described issue.

Steps for Testing

Prerequisites:

  • local Atlassian setup based on docker containers
  1. rebuild your bamboo-build-agent docker compose -f docker/atlassian.yml up bamboo-build-agent -d
  2. approve the access of the new build agent
  3. create a programming exercise -> exercise is created without errors and builds are triggered

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@florian-glombik florian-glombik self-assigned this Sep 27, 2023
@florian-glombik florian-glombik requested a review from a team as a code owner September 27, 2023 09:08
reschandreas
reschandreas previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@reschandreas reschandreas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected, LGTM

@florian-glombik florian-glombik added this to the 6.5.4 milestone Sep 27, 2023
Strohgelaender
Strohgelaender previously approved these changes Oct 2, 2023
View reviewed changes
laurenzfb
laurenzfb previously approved these changes Oct 2, 2023
View reviewed changes
MaximilianAnzinger
MaximilianAnzinger previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session

Kroko-fant
Kroko-fant previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@Kroko-fant Kroko-fant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me

@krusche krusche changed the title Development: Updating bamboo build agent version Development: Update bamboo build agent version Oct 3, 2023
@krusche krusche merged commit 027ab66 into develop Oct 3, 2023
9 of 11 checks passed
@krusche krusche deleted the chore/fix-local-atlassian-setup branch October 3, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximilianAnzinger MaximilianAnzinger MaximilianAnzinger left review comments

@laurenzfb laurenzfb laurenzfb left review comments

@Strohgelaender Strohgelaender Strohgelaender left review comments

@Kroko-fant Kroko-fant Kroko-fant left review comments

@reschandreas reschandreas reschandreas left review comments

Assignees

@florian-glombik florian-glombik

Labels
chore docker ready for review
Projects
None yet
Milestone
6.5.4
Development

Successfully merging this pull request may close these issues.
7 participants
@florian-glombik @reschandreas @Kroko-fant @Strohgelaender @laurenzfb @MaximilianAnzinger @krusche