Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add JavaDocs to UtilServices and Factories [3] #7271

Conversation

DominikRemo
Copy link
Contributor

@DominikRemo DominikRemo commented Sep 26, 2023

Checklist

General

Motivation and Context

Improve the readability of UtilServices and Factories by adding JavaDoc to the helper functions

Description

Added documentation to following files:

  • exam/ExamFactory.java
  • exam/ExamUtilService.java

Steps for Testing

JavaDoc changes only

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@DominikRemo DominikRemo changed the title Empty Commit Development: Add JavaDocs to UtilServices and Factories [3] Sep 26, 2023
…ain' into development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-3
@ls1intum ls1intum deleted a comment from github-actions bot Oct 4, 2023
@DominikRemo DominikRemo removed the stale label Oct 4, 2023
…ain' into development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-3
@DominikRemo DominikRemo marked this pull request as ready for review October 6, 2023 08:20
@DominikRemo DominikRemo requested a review from a team as a code owner October 6, 2023 08:20
laadvo

This comment was marked as resolved.

Next time before setting ready for review
@DominikRemo DominikRemo requested a review from laadvo October 6, 2023 10:39
Copy link
Contributor

@laadvo laadvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion

…ain' into development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-3
@DominikRemo DominikRemo merged commit 3b9359f into development/add-javadoc-to-utilservices-and-factories/main Oct 13, 2023
9 of 11 checks passed
@DominikRemo DominikRemo deleted the development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-3 branch October 13, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants