-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add JavaDocs to UtilServices and Factories [3]
#7271
Merged
DominikRemo
merged 8 commits into
development/add-javadoc-to-utilservices-and-factories/main
from
development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-3
Oct 13, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikRemo
changed the title
Empty Commit
Sep 26, 2023
Development
: Add JavaDocs to UtilServices and Factories [3]
42 tasks
…ain' into development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-3
…ain' into development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-3
Next time before setting ready for review
b-fein
approved these changes
Oct 7, 2023
laadvo
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small suggestion
…ain' into development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-3
DominikRemo
merged commit Oct 13, 2023
3b9359f
into
development/add-javadoc-to-utilservices-and-factories/main
9 of 11 checks passed
DominikRemo
deleted the
development/add-javadoc-to-utilservices-and-factories/add-javadoc-group-3
branch
October 13, 2023 05:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
Improve the readability of UtilServices and Factories by adding JavaDoc to the helper functions
Description
Added documentation to following files:
Steps for Testing
JavaDoc changes only
Review Progress
Code Review