-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iris
: Preserve settings on course and exercise update
#7265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
server
Pull requests that update Java code. (Added Automatically!)
labels
Sep 25, 2023
src/main/java/de/tum/in/www1/artemis/repository/iris/IrisSettingsRepository.java
Outdated
Show resolved
Hide resolved
…ngsRepository.java Co-authored-by: Lucas Welscher <[email protected]>
src/main/java/de/tum/in/www1/artemis/repository/CourseRepository.java
Outdated
Show resolved
Hide resolved
MichaelOwenDyer
previously approved these changes
Sep 25, 2023
JohannesStoehr
previously approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one suggestion. Other than that code LGTM 👍
src/main/java/de/tum/in/www1/artemis/service/iris/IrisSettingsService.java
Show resolved
Hide resolved
krusche
changed the title
Oct 3, 2023
Iris
: Preserve settings on course/exercise updateIris
: Preserve settings on course and exercise update
# Conflicts: # src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseService.java # src/test/java/de/tum/in/www1/artemis/course/CourseTestService.java
Hialus
dismissed stale reviews from JohannesStoehr and MichaelOwenDyer
via
October 3, 2023 10:59
85c2c0a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:Iris
ready for review
server
Pull requests that update Java code. (Added Automatically!)
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Only deploy on TS9
Checklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
Currently there is a bug, where the Iris settings are deleted for a course/programming exercise if they are updated.
Description
This PR fixes this behaviour by copying the Iris Settings into the new object.
Steps for Testing
Prerequisites:
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Server