Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix flaky CourseGitlabJenkinsIntegrationTest #7257

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

tobias-lippert
Copy link
Contributor

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.

Motivation and Context

CourseGitlabJenkinsIntegrationTest.testEditCourseRemoveExistingIcon is flaky at the moment.

Description

Added an await to make sure the icon file is deleted.

Steps for Testing

Code Review
Run the tests locally, e.g. when running it locally 1000 times it failed 8 times on my machine.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Test Coverage

unchanged

@tobias-lippert tobias-lippert requested a review from a team as a code owner September 23, 2023 20:45
@github-actions github-actions bot added the tests label Sep 23, 2023
@krusche krusche added this to the 6.5.2 milestone Sep 23, 2023
@krusche krusche merged commit c9e1fd8 into develop Sep 23, 2023
34 of 37 checks passed
@krusche krusche deleted the bugfix/flaky-course-icon-test branch September 23, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants