Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Cleanup temporary files when running tests #7234

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Development: Cleanup temporary files when running tests #7234

merged 6 commits into from
Sep 22, 2023

Conversation

Strohgelaender
Copy link
Contributor

@Strohgelaender Strohgelaender commented Sep 20, 2023 •
edited
Loading

Checklist

General

Motivation and Context

Similar to PR #7051 this PR fixes other instances where temporary files get created but not correctly cleaned up when running the server tests.

Steps for Testing

code review

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@Strohgelaender Strohgelaender requested a review from a team as a code owner September 20, 2023 19:11
@github-actions github-actions bot added the tests label Sep 20, 2023
@DominikRemo DominikRemo self-requested a review September 20, 2023 20:21
DominikRemo
DominikRemo approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@DominikRemo DominikRemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

laadvo
laadvo approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@laadvo laadvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍

@bassner bassner added this to the 6.5.2 milestone Sep 22, 2023
@krusche krusche merged commit 9e374db into develop Sep 22, 2023
@krusche krusche deleted the chore/rest-resources branch September 22, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-lippert tobias-lippert tobias-lippert approved these changes

@laadvo laadvo laadvo approved these changes

@DominikRemo DominikRemo DominikRemo approved these changes

@bassner bassner bassner approved these changes

Assignees

@Strohgelaender Strohgelaender

Labels
ready to merge small tests
Projects
None yet
Milestone
6.5.2
Development

Successfully merging this pull request may close these issues.
6 participants
@Strohgelaender @bassner @DominikRemo @laadvo @tobias-lippert @krusche