Development: Remove creation of successful file for E2E tests
#7219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
E2E Tests ran on Bamboo always reported a success state back to GH regardless of the actual build result. This was caused by the introduction of parallel E2E tests in #7054. Because of these changes, the exit state of the E2E tests was always 0, resulting in the creation of a successful file. Therefore, Bamboo always reported success to GH.
Description
This PR removes the creation of the successful file. I changed the E2E build pipelines for MySQL and Postgres to use the
bamboo_jobFailedvariable directly in Bamboo to determine the correct status that needs to be reported back to GH.Screenshots