Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Document the exam timeline #7201

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Development: Document the exam timeline #7201

merged 6 commits into from
Sep 22, 2023

Conversation

tobias-lippert
Copy link
Contributor

@tobias-lippert tobias-lippert commented Sep 15, 2023 •
edited
Loading

Checklist

General

Motivation and Context

The features I added are still missing documentation. This is the first PR to add documentation for one of my features.

Description

Added docs with screenshots.

Steps for Testing

Have a look at the code and the docs built in the pipeline.

Code Review

  • Code Review 1
  • Code Review 2

@tobias-lippert tobias-lippert requested a review from a team as a code owner September 15, 2023 06:41
@tobias-lippert tobias-lippert changed the title Documentation/exam timeline Documentation: Exam Timeline Sep 15, 2023
b-fein
b-fein previously approved these changes Sep 16, 2023
View reviewed changes
JohannesStoehr
JohannesStoehr previously approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looks good to me

laadvo
laadvo reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@laadvo laadvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor suggestions but looks good otherwise 👍

docs/user/exams/instructors_guide.rst Outdated Show resolved Hide resolved
docs/user/exams/instructors_guide.rst Outdated Show resolved Hide resolved
docs/user/exams/instructors_guide.rst Outdated Show resolved Hide resolved
docs/user/exams/instructors_guide.rst Outdated Show resolved Hide resolved
@tobias-lippert tobias-lippert added this to the 6.5.2 milestone Sep 21, 2023
laadvo
laadvo approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@laadvo laadvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for implementing my suggestions, LGTM

aplr
aplr approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@aplr aplr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@krusche krusche changed the title Documentation: Exam Timeline Development: Document the exam timeline Sep 22, 2023
@krusche krusche merged commit 819d4ca into develop Sep 22, 2023
@krusche krusche deleted the documentation/exam-timeline branch September 22, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laadvo laadvo laadvo approved these changes

@aplr aplr aplr approved these changes

@b-fein b-fein b-fein left review comments

@JohannesStoehr JohannesStoehr JohannesStoehr left review comments

Assignees

@tobias-lippert tobias-lippert

Labels
documentation ready to merge
Projects
None yet
Milestone
6.5.2
Development

Successfully merging this pull request may close these issues.
6 participants
@tobias-lippert @aplr @JohannesStoehr @b-fein @laadvo @krusche