Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Fix an issue on the user settings page #7195

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Strohgelaender
Copy link
Contributor

@Strohgelaender Strohgelaender commented Sep 13, 2023

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.

Motivation and Context

Fixes ARTEMIS-Z72.
Opening the user settings page leads to an error shown in the console.

Description

Removes a line that was added by mistake.

Steps for Testing

  1. Open the user settings page
  2. Verify that no error is present in the console

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@Strohgelaender Strohgelaender requested a review from a team as a code owner September 13, 2023 18:14
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Sep 13, 2023
Copy link
Contributor

@jakubriegel jakubriegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Tested locally, works

Copy link
Contributor

@DominikRemo DominikRemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@laadvo laadvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximiliansoelch maximiliansoelch added ready to merge maintainer-approved The feature maintainer has approved the PR and removed ready for review labels Sep 13, 2023
@krusche krusche added this to the 6.5.0 milestone Sep 14, 2023
@krusche krusche merged commit a51749b into develop Sep 14, 2023
59 of 61 checks passed
@krusche krusche deleted the bugfix/user-settings-error branch September 14, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) maintainer-approved The feature maintainer has approved the PR ready to merge sentry-issue small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants