Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix postgres incompatibility for conversation user information query #7190

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

lennart-keller
Copy link
Contributor

@lennart-keller lennart-keller commented Sep 13, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.

Motivation and Context

The query to retrieve user-related information about a conversation is incompatible with Postgres (see https://gist.github.com/TheZoker/66abc96cf0218d12ce888bda06a33dbc#file-e2e-postgres-error-log)

Description

The missing fields in the GROUP BY clause are added.

Steps for Testing

Prerequisites:

  • 1 User
  • PostgreSQL database
  1. Log in to Artemis
  2. Navigate to the messages tab of a course and confirm that the page loads.

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

No UI changes

@lennart-keller lennart-keller self-assigned this Sep 13, 2023
@lennart-keller lennart-keller requested a review from a team as a code owner September 13, 2023 08:51
@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Sep 13, 2023
Copy link
Contributor

@TheZoker TheZoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests seem to be fixed 👍

Copy link
Contributor

@jakubriegel jakubriegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍🏻

Btw, there should be a way to validate @Query agains different dbs

@krusche krusche merged commit a2f1397 into develop Sep 14, 2023
43 of 44 checks passed
@krusche krusche deleted the bugfix/user-conversation-information-postgres branch September 14, 2023 08:42
@krusche krusche added this to the 6.5.0 milestone Sep 14, 2023
@krusche krusche changed the title Development: Fix Postgres Incompatibility for conversation user information query Development: Fix postgres incompatibility for conversation user information query Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix ready for review server Pull requests that update Java code. (Added Automatically!) small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants