Programming exercises: Fix missing branch configuration
#7189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
server
jakubriegel
reviewed
Sep 13, 2023
src/main/java/de/tum/in/www1/artemis/web/rest/ProgrammingExerciseResource.java
Outdated
Show resolved
Hide resolved
|
Seems that the change is not yet working. Probably some JsonIgnore prevents this |
github-actions
bot
removed
the
client
reschandreas
approved these changes
Sep 13, 2023
jakubriegel
reviewed
Sep 14, 2023
| @@ -266,6 +266,9 @@ public ResponseEntity<ProgrammingExercise> updateProgrammingExercise(@RequestBod | |||
| // Forbid conversion between normal course exercise and exam exercise | |||
| exerciseService.checkForConversionBetweenExamAndCourseExercise(updatedProgrammingExercise, programmingExerciseBeforeUpdate, ENTITY_NAME); | |||
|
|
|||
| // Ignore changes to the default branch | |||
There was a problem hiding this comment.
Is this still a temporal solution or will is stay here for good?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
The branch attribute was missing in the client. Therefore, whenever an instructor edits a programming exercise, the branch was set to null in the database which is problematic, because the branch information might be needed in follow-up operations.
Description
Since the user should not even be able to change the branch name after creation, we override it in the update endpoint before saving the entity.
Steps for Testing
Prerequisites:
Review Progress
Code Review
Manual Tests