-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Export files embedded with HTML syntax
#7187
Conversation
Programming Exercises
: Export files embedded with HTML syntaxDevelopment
: Export files embedded with HTML syntax
src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseExportService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseExportService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseExportService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me now
src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseExportService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseExportService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseExportService.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Maximilian Anzinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Tested on TS2, works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in the testing session, works as described
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session. Worked as expected!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in testing session, works as expected.
Development
: Export files embedded with HTML syntaxProgramming exercises
: Export files embedded with HTML syntax
Checklist
General
Server
Motivation and Context
The export of a programming exercise doesn't contain files embedded using HTML syntax because the regex doesn't match them.
Description
Added a second regex to also match files embedded with HTML syntax refactored some code to reuse logic for both regex expressions.
Steps for Testing
Prerequisites:
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Server
Screenshots