Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Export files embedded with HTML syntax #7187

Merged
merged 6 commits into from
Sep 15, 2023

Conversation

tobias-lippert
Copy link
Contributor

@tobias-lippert tobias-lippert commented Sep 12, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I documented the Java code using JavaDoc style.

Motivation and Context

The export of a programming exercise doesn't contain files embedded using HTML syntax because the regex doesn't match them.

Description

Added a second regex to also match files embedded with HTML syntax refactored some code to reuse logic for both regex expressions.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Programming exercise
  1. Embedded some files in the problem statement using both markdown and html syntax
  2. Export (Download) the exercise
  3. Verify that the export contains all embedded files.

Review Progress

Performance Review

  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Server

Class/File Line Coverage Confirmation (assert/expect) Comment
ProgrammingExerciseExportService.java 86% my changes are covered

Screenshots

@tobias-lippert tobias-lippert requested a review from a team as a code owner September 12, 2023 15:05
@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) labels Sep 12, 2023
@tobias-lippert tobias-lippert changed the title Programming Exercises: Export files embedded with HTML syntax Development: Export files embedded with HTML syntax Sep 12, 2023
JohannesStoehr
JohannesStoehr previously approved these changes Sep 14, 2023
Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me now

Co-authored-by: Maximilian Anzinger <[email protected]>
Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM
Tested on TS2, works

@tobias-lippert tobias-lippert added this to the 6.5.0 milestone Sep 14, 2023
Copy link
Contributor

@dearjasmina dearjasmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in the testing session, works as described

Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session. Worked as expected!

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in testing session, works as expected.

@krusche krusche changed the title Development: Export files embedded with HTML syntax Programming exercises: Export files embedded with HTML syntax Sep 15, 2023
@krusche krusche merged commit 2a6c44b into develop Sep 15, 2023
23 of 25 checks passed
@krusche krusche deleted the bugfix/pe-export-match-more-embedded-files branch September 15, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge server Pull requests that update Java code. (Added Automatically!) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants