-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiz exercise
: Show the last grades in practice mode
#7182
Conversation
src/main/webapp/app/exercises/shared/exercise-scores/exercise-scores.component.html
Outdated
Show resolved
Hide resolved
Quiz exercise
: how the last grades in practice mode
Quiz exercise
: how the last grades in practice modeQuiz exercise
: Show the last grades in practice mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS1
Creating and solving a quiz exercise is working as expected. The grades are shown normally to the instructor.
When the quiz is practiced, the new last grade is updated
However, the student keeps the grade obtained during the quiz (not the practice grade)
The exported grades are not affected by the practice
Also, the consolidated view of the grades is not affected by the practice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand the issue myself and the description of the mentioned issue, the table should not show the ungraded result but the last graded result instead. As an instructor I want to see the grade that the student actually received in the exercise and not some practice result later on
The issue was when the student solved the quiz as practice, the result just showed nothing. And the header of that column says "Last result". |
I agree with @JohannesStoehr. While this solves the issue that nothing was shown as a result, it now shows the wrong result. This page should contain an overview of all graded results and should not show the practice result. |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
I will continue working on that change |
Work is continued under #7252 |
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
On the quiz exercises scores page in the instructor perspective, the grades is not shown for the attempts in practice mode. Fixed the open issue #7150.
Description
I changed the html file for the exercise scores webpage. In the cell of the datatable shown in this page, the option of shownUngradedResults was set to false, and now is set to true. So grades of non-graded attempts in practice mode could also be shown in the table.
Steps for Testing
Prerequisites:
Instructor:
Student
Instructor:
Student:
Instructor:
Review Progress
Performance Review
Code Review
Manual Tests
Screenshots
The scores button could be found here in Course Management -> Quiz Exercises:
Before, no graded result is shown for the second attempt in practice mode:
After, result is shown there: