Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz exercise: Show the last grades in practice mode #7182

Closed
wants to merge 4 commits into from

Conversation

Xinyannnnnn
Copy link

@Xinyannnnnn Xinyannnnnn commented Sep 12, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

On the quiz exercises scores page in the instructor perspective, the grades is not shown for the attempts in practice mode. Fixed the open issue #7150.

Description

I changed the html file for the exercise scores webpage. In the cell of the datatable shown in this page, the option of shownUngradedResults was set to false, and now is set to true. So grades of non-graded attempts in practice mode could also be shown in the table.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Course
  • 1 Quiz Exercise

Instructor:

  1. Create a Quiz Exercise
    Student
  2. Solve the quiz (wait until the quiz ends)
  3. Verify your grade
    Instructor:
  4. Verify the student's grade
  5. Release the quiz for practice
    Student:
  6. Practice the quiz
  7. Check the new obtained grade
  8. Verify in statistics that your previous grade didn't change
    Instructor:
  9. In score of the quiz exercise, check the new grade obtained by the student
  10. In the score of the course, check that the previous score didn't change.

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

The scores button could be found here in Course Management -> Quiz Exercises:

screenshot 1

Before, no graded result is shown for the second attempt in practice mode:

screenshot 2

After, result is shown there:

screenshot 3

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Sep 12, 2023
@Santia-go Santia-go changed the title bugfix to show the last grades in practice mode Quiz exercise: how the last grades in practice mode Sep 12, 2023
@Santia-go Santia-go changed the title Quiz exercise: how the last grades in practice mode Quiz exercise: Show the last grades in practice mode Sep 12, 2023
@Xinyannnnnn Xinyannnnnn marked this pull request as ready for review September 13, 2023 00:37
@Xinyannnnnn Xinyannnnnn requested a review from a team as a code owner September 13, 2023 00:37
Copy link
Contributor

@Santia-go Santia-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS1

Creating and solving a quiz exercise is working as expected. The grades are shown normally to the instructor.

Screenshot 2023-09-13 at 09 55 48

When the quiz is practiced, the new last grade is updated

Screenshot 2023-09-13 at 09 58 10

However, the student keeps the grade obtained during the quiz (not the practice grade)

Screenshot 2023-09-13 at 10 10 56

The exported grades are not affected by the practice

image

Also, the consolidated view of the grades is not affected by the practice

image

Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand the issue myself and the description of the mentioned issue, the table should not show the ungraded result but the last graded result instead. As an instructor I want to see the grade that the student actually received in the exercise and not some practice result later on

@Santia-go Santia-go closed this Sep 13, 2023
@Santia-go Santia-go reopened this Sep 13, 2023
@Santia-go
Copy link
Contributor

Santia-go commented Sep 13, 2023

As far as I understand the issue myself and the description of the mentioned issue, the table should not show the ungraded result but the last graded result instead. As an instructor I want to see the grade that the student actually received in the exercise and not some practice result later on

The issue was when the student solved the quiz as practice, the result just showed nothing. And the header of that column says "Last result".

@Strohgelaender
Copy link
Contributor

I agree with @JohannesStoehr. While this solves the issue that nothing was shown as a result, it now shows the wrong result. This page should contain an overview of all graded results and should not show the practice result.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@jakubriegel
Copy link
Contributor

I will continue working on that change

@jakubriegel jakubriegel removed the stale label Sep 23, 2023
@jakubriegel
Copy link
Contributor

Work is continued under #7252

@krusche krusche deleted the bugfix-quiz-grade-practice-mode branch April 22, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) component:Quiz no-stale small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants