Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris: Replace or remove unnecessary client dependencies #7173

Merged
merged 8 commits into from
Sep 14, 2023

Conversation

bassner
Copy link
Member

@bassner bassner commented Sep 11, 2023

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.

Motivation and Context

The IRIS UI is currently using these dependencies:

  • angular2-draggable: Used to move and resize the chat window. Can be replaced with already used interact.js.
  • angular-animations: Provides a predefined animation. We don't need that at all
  • css-element-queries: Used to monitor the resizing of the chat window and storing the values in local storage. We don't need that at all

Description

Remove or replace dependencies as described above.

Steps for Testing

Prerequisites:

  • 1 Student
  • 1 Programming Exercise with IRIS enabled on TS9
  1. Go to the exercise view
  2. Open the chat window
  3. Verify that you can drag the window around
  4. Verify that you can resize the window on all edges
  5. Verify that it expands to 95vw and 85vh if you click the fullscreen icon
  6. Verify that it reverts back to default if you click it again
  7. Verify that the icon automatically changes if you manually drag the window larger than 95vm and 85vh

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

@bassner bassner self-assigned this Sep 11, 2023
@github-actions github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) labels Sep 11, 2023
@bassner bassner marked this pull request as ready for review September 11, 2023 15:11
@bassner bassner requested a review from a team as a code owner September 11, 2023 15:11
@bassner bassner merged commit 280cfc7 into develop-iris Sep 14, 2023
11 of 15 checks passed
@bassner bassner deleted the iris/replace-client-deps branch September 14, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready for review tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant