Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Update client and server dependencies #7163

Merged
merged 7 commits into from
Sep 15, 2023
Merged

Development: Update client and server dependencies #7163

merged 7 commits into from
Sep 15, 2023

Conversation

krusche
Copy link
Member

@krusche krusche commented Sep 8, 2023 •
edited by MaximilianAnzinger
Loading

  • I tested all changes and their related features with all corresponding user types on a test server.
  • All relevant checks pass.

Testing steps

  • Try out all PDF features, in particular slide splitting when uploading a PDF (with various configurations as instructor) and merging multiple PDFs from lecture units (download as student)

@krusche krusche requested a review from a team as a code owner September 8, 2023 19:16
@krusche krusche changed the title Development: Update dependencies Development: Update client and server dependencies Sep 8, 2023
@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) labels Sep 9, 2023
@krusche krusche added this to the 6.5.0 milestone Sep 9, 2023
tobias-lippert
tobias-lippert approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@tobias-lippert tobias-lippert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM
Tested in testing session. Everything we tested regarding pdf manipulation worked.

dearjasmina
dearjasmina approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@dearjasmina dearjasmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in the testing session, works as expected

Strohgelaender
Strohgelaender approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in testing session, merging pds and uploading exam users still works as expected.

code looks good as well.

laurenzfb
laurenzfb approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session. Worked as expected

aplr
aplr approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@aplr aplr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session, PDF split & merge does not break

@krusche krusche merged commit 1207f3d into develop Sep 15, 2023
33 of 35 checks passed
@krusche krusche deleted the chore/dependency-updates-september-2023 branch September 15, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-lippert tobias-lippert tobias-lippert approved these changes

@laurenzfb laurenzfb laurenzfb approved these changes

@Strohgelaender Strohgelaender Strohgelaender approved these changes

@dearjasmina dearjasmina dearjasmina approved these changes

@aplr aplr aplr approved these changes

Assignees

@krusche krusche

@MaximilianAnzinger MaximilianAnzinger

Labels
ready to merge server Pull requests that update Java code. (Added Automatically!) tests
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
7 participants
@krusche @aplr @dearjasmina @Strohgelaender @laurenzfb @tobias-lippert @MaximilianAnzinger