Development: Update GitLab and Jenkins setup in development documentation
#7145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reschandreas
changed the title
Development: Update GitLab and Jenkins Setup in Development Setup DocumentationDevelopment: Update GitLab and Jenkins Setup in Development Documentation
jakubriegel
previously approved these changes
Sep 9, 2023
b-fein
previously approved these changes
Sep 10, 2023
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
florian-glombik
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Thank you for keeping the setup documentation up to date!
I do only have some minor comments, however, I would appreciate it if the description of how to navigate to the Timestamper Configuration could be adjusted, as I was confused by the current description.
reschandreas
dismissed stale reviews from b-fein and jakubriegel
via
5c03711
b-fein
approved these changes
Sep 19, 2023
florian-glombik
approved these changes
Sep 19, 2023
dearjasmina
approved these changes
Sep 22, 2023
krusche
changed the title
Development: Update GitLab and Jenkins Setup in Development DocumentationDevelopment: Update GitLab and Jenkins setup in development documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
The Screenshots and some commands/navigation hints were outdated. I had to setup GitLab and Jenkins recently and thought I'd help the next person to do so.
Description
Just updating the documentation to keep it accurate.
Steps for Testing
https://artemis-platform--7145.org.readthedocs.build/en/7145/dev/setup.html#jenkins-and-gitlab-setup
Look at your GitLab/Jenkins Setup and see that the new screenshots are correct, the process only changes for the creation of the administrator user, as it is not possible anymore to create a password upon user creation.
Review Progress
Code Review
Manual Tests
Exam Mode Test