-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exam mode
: Show number of accepted complaints in assessment dashboard
#7144
Exam mode
: Show number of accepted complaints in assessment dashboard
#7144
Conversation
src/main/webapp/app/shared/dashboards/tutor-leaderboard/tutor-leaderboard.component.ts
Outdated
Show resolved
Hide resolved
src/main/webapp/app/shared/dashboards/tutor-leaderboard/tutor-leaderboard.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
src/main/webapp/app/shared/dashboards/tutor-leaderboard/tutor-leaderboard.component.html
Outdated
Show resolved
Hide resolved
02ed32f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the code. Lgtm
Exam
: Show number of accepted complaints in assessment dashboardExam mode
: Show number of accepted complaints in assessment dashboard
Checklist
General
Client
Motivation and Context
Fixes #6419
in the assessment dashboard for exam exercises, the number of accepted complaints is not displayed. The reason for this problem is that the number of accepted complaints is only displayed if the property
course
is present, but exam exercises don't have this property.Description
isAtLeastInstructor
is not a property of the course but of the exercise, so we need to check for that tooSteps for Testing
Review Progress
Code Review
Manual Tests