Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Show number of accepted complaints in assessment dashboard #7144

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Exam mode: Show number of accepted complaints in assessment dashboard #7144

merged 8 commits into from
Oct 3, 2023

Conversation

valentin-boehm
Copy link
Contributor

@valentin-boehm valentin-boehm commented Sep 5, 2023

Checklist

General

Client

Motivation and Context

Fixes #6419
in the assessment dashboard for exam exercises, the number of accepted complaints is not displayed. The reason for this problem is that the number of accepted complaints is only displayed if the property course is present, but exam exercises don't have this property.

Description

  • For exam exercises we need to use the course of the exam, not the course of the exercise.
  • In exam mode, the property isAtLeastInstructor is not a property of the course but of the exercise, so we need to check for that too
  • The URL for exam complaints is different from the one for normal exercises, so that needs to be adapted.

Steps for Testing

  1. Create an exam with at least 1 exercise
  2. As a student: Participate in the exam
  3. As a tutor: Evaluate the submission
  4. As student: File a complaint
  5. As a tutor: Accept the complaint
  6. As an instructor: Make sure that the tutor leaderboard is displayed correctly in the exam dashboard and the exercise assessment dashboard. Verify that the number of accepted complaints links to the correct page.
  7. As a tutor: Verify that the number of accepted complaints does not link to the complaint list.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Sep 5, 2023
@valentin-boehm valentin-boehm marked this pull request as ready for review September 5, 2023 15:15
@valentin-boehm valentin-boehm requested a review from a team as a code owner September 5, 2023 15:15
Strohgelaender
Strohgelaender previously approved these changes Sep 7, 2023
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

MichaelOwenDyer
MichaelOwenDyer previously approved these changes Sep 8, 2023
Copy link
Contributor

@MichaelOwenDyer MichaelOwenDyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

dearjasmina
dearjasmina previously approved these changes Sep 8, 2023
Copy link
Contributor

@dearjasmina dearjasmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@github-actions
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the code. Lgtm

@krusche krusche changed the title Exam: Show number of accepted complaints in assessment dashboard Exam mode: Show number of accepted complaints in assessment dashboard Oct 3, 2023
@krusche krusche added this to the 6.5.4 milestone Oct 3, 2023
@krusche krusche merged commit de70473 into ls1intum:develop Oct 3, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exam: Colums for complaint responses and average points swapped assessment-dashboard
7 participants