-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iris
: Fix server tests
#7133
Iris
: Fix server tests
#7133
Conversation
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through the tests
Left a question and a suggestion
src/test/java/de/tum/in/www1/artemis/iris/IrisMessageIntegrationTest.java
Show resolved
Hide resolved
src/test/java/de/tum/in/www1/artemis/iris/IrisMessageIntegrationTest.java
Show resolved
Hide resolved
src/test/java/de/tum/in/www1/artemis/iris/AbstractIrisIntegrationTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two suggestions regarding the tests in IrisMessageIntegrationTest
in general:
- You could consider using less users (instead of 14, I think 2 should suffice for all tests in
userUtilService.addUsers(TEST_PREFIX, 14,..)
) - There is a lot of duplicated code making the tests confuscated. You could consider extracting test setup into the
@BeforeEach
and other helper methods
# Conflicts: # src/test/java/de/tum/in/www1/artemis/AbstractSpringIntegrationBambooBitbucketJiraTest.java
|
Checklist
General
and was confirmed by another developer on a test server.Server
Motivation and Context
Currently on develop-iris the server tests are failing. Since it is a protected branch, the fixes are done here.
Description
Changes:
IrisMessageContentRepository
IrisConnectorService::getOfferedModels
/api/v1/models
endpoint of PyrisIrisConnectorService
Review Progress
Performance Review
Code Review
Test Coverage