Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Allow instructors to extend exam time #7119

Merged
merged 48 commits into from
Sep 18, 2023

Display absolute working time

a69f318
Select commit
Loading
Failed to load commit list.
Merged

Exam mode: Allow instructors to extend exam time #7119

Display absolute working time
a69f318
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Teamscale / teamscale-findings required action Sep 16, 2023 in 0s

Teamscale

This pull request would introduce 7 new findings

Details

Teamscale's logo 7 added, 29 in changed code, 5 removed 55 Test Gaps (100%) tested changes: 0|untested changes: 41|untested additions: 14

  • src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseScheduleServiceTest.java#36: Star import of de.tum.in.www1.artemis.domain.enumeration.* should not be used (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/service/messaging/InstanceMessageReceiveService.java#298: Interface comment missing (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/service/scheduled/ProgrammingExerciseScheduleService.java#8: Star import of java.util.function.* should not be used (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java#28: Star import of org.springframework.http.* should not be used (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/StudentExamResource.java#44: Star import of de.tum.in.www1.artemis.web.rest.errors.* should not be used (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java#43: Star import of de.tum.in.www1.artemis.service.* should not be used (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java#253: Violation of method length threshold (source lines of code) of 30: 37 (view in Teamscale)

Annotations

Check warning on line 36 in src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseScheduleServiceTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseScheduleServiceTest.java#L36 

Star import of `de.tum.in.www1.artemis.domain.enumeration.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Ftime-extension%3AHEAD&id=03A0E8FE2FEB9BA2ACCCC5913A170C6F

Check warning on line 298 in src/main/java/de/tum/in/www1/artemis/service/messaging/InstanceMessageReceiveService.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/service/messaging/InstanceMessageReceiveService.java#L298 

In this file 24 interface comments are missing. Consider adding explanatory comments or restricting the visibility.

View in Teamscale:
https://teamscale.io/activity.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Ftime-extension%3A1694871322000

Check warning on line 8 in src/main/java/de/tum/in/www1/artemis/service/scheduled/ProgrammingExerciseScheduleService.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/service/scheduled/ProgrammingExerciseScheduleService.java#L8 

Star import of `java.util.function.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Ftime-extension%3AHEAD&id=ABF7E815F928BC37680E3E173F0F6862

Check warning on line 305 in src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java#L253-L305 

This method is a bit lengthy [0]. Consider shortening it, e.g. by extracting code blocks into separate methods.

[0] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Ftime-extension%3AHEAD&id=0433506A73DFB1F85A8D141737499971

Check warning on line 43 in src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java#L43 

Star import of `de.tum.in.www1.artemis.service.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Ftime-extension%3AHEAD&id=3CD1A9BE3657370319C2502172E09DB0

Check warning on line 28 in src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java#L28 

Star import of `org.springframework.http.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Ftime-extension%3AHEAD&id=A44F8D1D29B9608662421517AC9205B5

Check warning on line 44 in src/main/java/de/tum/in/www1/artemis/web/rest/StudentExamResource.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/StudentExamResource.java#L44 

Star import of `de.tum.in.www1.artemis.web.rest.errors.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Fexam-mode%2Ftime-extension%3AHEAD&id=7407EAFDB26FD41D92B442F8ED4359C1
View more details on Teamscale