Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: Configure messaging code of conduct #7118

Merged
merged 17 commits into from
Sep 15, 2023

Conversation

nityanandaz
Copy link
Contributor

@nityanandaz nityanandaz commented Aug 30, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

#7085: Write and edit a course's code of conduct

Description

Add a markdown editor to the update course component and persist the code of conduct.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 course
  1. Log in to Artemis
  2. Navigate to course administration
  3. Select a course
  4. Edit the course
  5. Enable messaging
  6. Write a code of conduct
  7. Save
  8. Edit again, see that Artemis persists the code of conduct

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Client

Class/File Line Coverage Confirmation (assert/expect)
course-update.component.ts 81.01%
course.model.ts 100%
course-conversations.component.ts 100%

Server

Class/File Line Coverage Confirmation (assert/expect)
Course.java 92%

Screenshots

Screenshot 2023-09-07 at 17 14 11 Screenshot 2023-09-07 at 17 14 23

@nityanandaz nityanandaz added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) component:Communication labels Aug 30, 2023
@nityanandaz nityanandaz self-assigned this Aug 30, 2023
@github-actions github-actions bot added the database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. label Aug 30, 2023
@krusche krusche marked this pull request as ready for review September 4, 2023 14:35
@krusche krusche requested a review from a team as a code owner September 4, 2023 14:35
src/main/resources/config/liquibase/master.xml Outdated Show resolved Hide resolved
src/main/webapp/i18n/de/conversation.json Outdated Show resolved Hide resolved
src/main/webapp/i18n/de/course.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the tests label Sep 7, 2023
Copy link
Contributor

@jakubriegel jakubriegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on ts1

Copy link
Contributor

@pal03377 pal03377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS1. I also looked at the code, which looks good!

Copy link
Contributor

@MarkusPaulsen MarkusPaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on TS1

Copy link
Contributor

@Kroko-fant Kroko-fant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looks good to me also tested in a testing session

Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve code

@bassner bassner added this to the 6.5.0 milestone Sep 15, 2023
@bassner bassner merged commit 233dbd1 into develop Sep 15, 2023
22 of 32 checks passed
@bassner bassner deleted the 7085/v2/configure-messaging-code-of-conduct branch September 15, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) component:Communication database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. ready to merge server Pull requests that update Java code. (Added Automatically!) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants