-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iris
: Fix two UX issues
#7115
Merged
Merged
Iris
: Fix two UX issues
#7115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
server
Pull requests that update Java code. (Added Automatically!)
client
Pull requests that update TypeScript code. (Added Automatically!)
labels
Aug 30, 2023
❌ Unable to deploy to test servers ❌Testserver "artemis-test9.artemis.cit.tum.de" is already in use by PR #6931. |
github-actions
bot
added
the
deployment-error
Added by deployment workflows if an error occured
label
Sep 12, 2023
RY997
removed
the
deployment-error
Added by deployment workflows if an error occured
label
Sep 12, 2023
RY997
reviewed
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code overall looks good to me, leaving two small comments.
And will test it after ts9 is released.
RY997
temporarily deployed
to
artemis-test9.artemis.cit.tum.de
September 14, 2023 08:29 — with
GitHub Actions
Inactive
github-actions
bot
added
lock:artemis-test9
and removed
deploy:artemis-test9
Testserver for Project Theia
labels
Sep 14, 2023
# Conflicts: # src/main/webapp/app/iris/exercise-chatbot/exercise-chatwidget/exercise-chat-widget.component.html
bassner
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Pull requests that update TypeScript code. (Added Automatically!)
component:Iris
ready for review
server
Pull requests that update Java code. (Added Automatically!)
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
There were three minor issues with the client code of Iris:
Description
This PR fixes all three issues:
Steps for Testing
(Don't be scared by the length, they are just very detailed 😉)
Prerequisites:
{{#system~}}
to{{system~}}
{{system~}}
to{{#system~}}
!Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots