-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive learning
: Extend learning path feature to recommend sequence of lecture units and exercises
#7113
Adaptive learning
: Extend learning path feature to recommend sequence of lecture units and exercises
#7113
Conversation
…-path/participation/exercises
…-path/participation/exercises
…-path/participation/exercises
…-path/participation/exercises
Co-authored-by: Johannes Stöhr <[email protected]>
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove Code after merges
src/main/java/de/tum/in/www1/artemis/service/CompetencyProgressService.java
Outdated
Show resolved
Hide resolved
src/test/java/de/tum/in/www1/artemis/service/LearningPathServiceTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session on ts1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts1, the described use case worked fine (split path is now displayed sequentially)
A view points out of scope for this PR:
- the continue button was always disabled (not quite sure if the up down arrow solution is in another PR)
- I did not understand how to delete and modify competency relations
- Deleting a competency that is linked via relation did not work (
400
as response)
@florian-glombik thank you for your review 👍
the continue button & sidebar is reworked and fixed in #7235
this is unrelated to this PR, but you can click on the respective edge and delete it that way.
do you know if this is also the case on develop? I'll take a look at it but this is an unrelated issue. |
Checklist
General
Server
Motivation and Context
We want to provide a sequential order of lecture units and exercises for students participating via the learning paths feature.
Description
This PR adds the second half for generating this sequential order by recommending an order of learning objects within the competencies.
The LearningPathService is now split into the
LearningPathService
that should be used by other components and the sub-servicesLearningPathRecommendationService
andLearningPathNgxSercive
that handle the corresponding sub-tasks.In addition to recommending an order of competencies, the recommendation now includes a suggested order of the learning objects (lecture units and exercises). The recommender will select exercises by difficulty level according to the prior performance of the student and also recommend repetitions of already completed exercises if the achieved score is comparably low.
Steps for Testing
Prerequisites:
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Server
�
Screenshots
As this PR doesn't change the UI there are no screenshots of shiny new components, just a comparison between the old graph received from the server (in participation view) and the new one:
Previously:
Now (excludes completed exercises and displays linear path):