Development: Refactor ExamIntegrationTest
#7112
Teamscale
This pull request would introduce 26 new findings
Details
- src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#31: Star import of
de.tum.in.www1.artemis.domain.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#45: Star import of
de.tum.in.www1.artemis.repository.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamUserIntegrationTest.java#19: Star import of
org.springframework.http.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#135: Method
testUpdateExam_rescheduleProgramming_visibleDateChangedviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExerciseGroupIntegrationTest.java#7: Star import of
java.util.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java#41: Star import of
de.tum.in.www1.artemis.repository.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamFactory.java#11: Star import of
de.tum.in.www1.artemis.web.rest.dto.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java#186: Clone with 2 instances of length 11 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exam/ExamRegistrationIntegrationTest.java#74: Clone with 2 instances of length 10 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exam/ExamRegistrationIntegrationTest.java#8: Star import of
java.util.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java#226: Clone with 2 instances of length 11 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#290: Method
testDeleteStudent_AfterParticipatingInExamviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#145: Method
testUpdateExam_rescheduleProgramming_startDateChangedviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#34: Star import of
de.tum.in.www1.artemis.domain.exam.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#1: Violation of file size threshold (source lines of code) of 750: 840 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#119: Method
testUpdateExam_rescheduleProgramming_visibleAndStartDateChangedviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#262: Method
testImportExamWithProgrammingExercise_preCheckFailedviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#11: Star import of
java.util.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamFactory.java#10: Star import of
de.tum.in.www1.artemis.domain.exam.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#39: Star import of
de.tum.in.www1.artemis.repository.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamUserIntegrationTest.java#10: Star import of
java.util.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java#27: Star import of
de.tum.in.www1.artemis.domain.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/TestExamIntegrationTest.java#61: Clone with 2 instances of length 10 (view in Teamscale)
- src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#191: Method
testRemovingAllStudents_AfterParticipatingInExamviolates naming convention. Should be one of[a-z][a-zA-Z0-9]*(view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java#29: Star import of
de.tum.in.www1.artemis.domain.exam.*should not be used (view in Teamscale) - src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#55: Star import of
de.tum.in.www1.artemis.web.rest.dto.*should not be used (view in Teamscale)
Annotations
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#L11
Star import of `java.util.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=312E4ED8BA389151DC9B7AEB81C79C70
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#L34
Star import of `de.tum.in.www1.artemis.domain.exam.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=3CA0E50F77B750D67F564445DE48C310
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#L55
Star import of `de.tum.in.www1.artemis.web.rest.dto.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=47EBD2B21B5E1255618F82857880B463
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#L290
Method `testDeleteStudent_AfterParticipatingInExam` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=5DD03950E75441E0953F52220D9EECAA
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#L1
Violation of file size threshold (source lines of code) of 750: 840
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=7AC71C35CD545A3E69FF31E6C8B74503
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#L45
Star import of `de.tum.in.www1.artemis.repository.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=CFB024D7C5A3129A581B24C4BE9CF894
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#L31
Star import of `de.tum.in.www1.artemis.domain.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=D0920E8BDEC1C088A0B7CACC771C327D
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamParticipationIntegrationTest.java#L191
Method `testRemovingAllStudents_AfterParticipatingInExam` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=D24FF276AF454DA15056E858984EDE1B
Check warning on line 19 in src/test/java/de/tum/in/www1/artemis/exam/ExamUserIntegrationTest.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamUserIntegrationTest.java#L19
[New] Star import of `org.springframework.http.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=BADB03E460458D9D339F3BFFD9528CE5
Check warning on line 10 in src/test/java/de/tum/in/www1/artemis/exam/ExamUserIntegrationTest.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamUserIntegrationTest.java#L10
[New] Star import of `java.util.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=CCCCE973D62055543D423578D0FDD979
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#L145
[New] Method `testUpdateExam_rescheduleProgramming_startDateChanged` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=3AE6DA93C237C4C7135AC61F23D6E06C
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#L135
Method `testUpdateExam_rescheduleProgramming_visibleDateChanged` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=654F6FC33BEB769EF3969AE7F2DDBA9C
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#L39
Star import of `de.tum.in.www1.artemis.repository.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=7ECAE046632142E4EED568B0CF5CCECE
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#L119
Method `testUpdateExam_rescheduleProgramming_visibleAndStartDateChanged` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=A30C011A68321313B959A2754825460C
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ProgrammingExamIntegrationTest.java#L262
Method `testImportExamWithProgrammingExercise_preCheckFailed` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=E3AB065943120AF5BBACC54897A2FA8D
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExerciseGroupIntegrationTest.java#L7
Star import of `java.util.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=1191E18A1F30DBCECD401029EC953EFA
Check warning on line 29 in src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java#L29
Star import of `de.tum.in.www1.artemis.domain.exam.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=1215032ED0A461A23E957234CFB92DAC
Check warning on line 41 in src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java#L41
Star import of `de.tum.in.www1.artemis.repository.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=5BBDD498A582D13D0A2661B2572C8E29
Check warning on line 242 in src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java#L226-L242
Clone with 2 instances of length 11
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=9651B45F215218CB7294D00D674085AA
Check warning on line 202 in src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java#L186-L202
Clone with 2 instances of length 11
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=D92A4254A2A90A408BB588C71151B847
Check warning on line 27 in src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamStartTest.java#L27
Star import of `de.tum.in.www1.artemis.domain.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=E90B5269F6AFE397B4573EA78EBCB4BA
Check warning on line 10 in src/test/java/de/tum/in/www1/artemis/exam/ExamFactory.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamFactory.java#L10
Star import of `de.tum.in.www1.artemis.domain.exam.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=982D02AE9868D5E32F0FBD6BA99D35EF
Check warning on line 11 in src/test/java/de/tum/in/www1/artemis/exam/ExamFactory.java
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamFactory.java#L11
Star import of `de.tum.in.www1.artemis.web.rest.dto.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=C87B44799524010D0A8E256EDD48EC71
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamRegistrationIntegrationTest.java#L8
Star import of `java.util.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=03B17812ED4DDBF17BA48660F33A6489
teamscale / teamscale-findings
src/test/java/de/tum/in/www1/artemis/exam/ExamRegistrationIntegrationTest.java#L74-L92
Clone with 2 instances of length 10
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=development%2Frefactor-ExamIntegrationTest%3AHEAD&id=B350A22D55B2868852BF812C79768399