-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Start bamboo-build-agent after bamboo container is healthy in development setup
#7082
Conversation
a86cec7
to
809f4a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One optional revert in the comments
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally, works as expected: The build agent container now waits for bamboo to start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works as expected 👍
General
: Start bamboo-build-agent after bamboo container is healthy in development setupDevelopment
: Start bamboo-build-agent after bamboo container is healthy in development setup
Checklist
General
Motivation and Context
I am working locally with the Atlassian suite and noticed on starting all the containers that the build agent is always existing and thus, programming exercises can't be worked on unless calling
docker compose -f docker/atlassian.yml up -d
again after bamboo is available.Description
Right now,
docker compose -f docker/atlassian.yml up -d
will start all containers, but the bamboo agent is faster on the startup, tries to contact bamboo, and gets connection refused. With the health check anddepends
in the docker-compose.yml we now wait for some time until the status page of bamboo is available and then start the build agent. This makes the whole Atlassian suite a bit nicer to work with locally, and the build agent does not silently fail right after the start.Steps for Testing
Prerequisites:
docker compose -f docker/atlassian.yml up -d
docker compose -f docker/atlassian.yml ps -a
that no container is ExitedReview Progress
Code Review
Manual Tests