Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Start bamboo-build-agent after bamboo container is healthy in development setup #7082

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

reschandreas
Copy link
Contributor

@reschandreas reschandreas commented Aug 15, 2023

Checklist

General

  • Language: I followed the [guidelines for inclusive, diversity-sensitive, and appreciative language (https://docs.artemis.cit.tum.de/dev/guidelines/language-guidelines/).
  • I chose a title conforming to the naming conventions for pull requests.
  • This change does not affect Artemis itself, only the development setup

Motivation and Context

I am working locally with the Atlassian suite and noticed on starting all the containers that the build agent is always existing and thus, programming exercises can't be worked on unless calling docker compose -f docker/atlassian.yml up -d again after bamboo is available.

Description

Right now, docker compose -f docker/atlassian.yml up -d will start all containers, but the bamboo agent is faster on the startup, tries to contact bamboo, and gets connection refused. With the health check and depends in the docker-compose.yml we now wait for some time until the status page of bamboo is available and then start the build agent. This makes the whole Atlassian suite a bit nicer to work with locally, and the build agent does not silently fail right after the start.

Steps for Testing

Prerequisites:

  • docker
  1. call docker compose -f docker/atlassian.yml up -d
  2. wait until all containers are started and are healthy/running
  3. make sure with docker compose -f docker/atlassian.yml ps -a that no container is Exited

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

docker/atlassian.yml Show resolved Hide resolved
docker/atlassian.yml Show resolved Hide resolved
@reschandreas reschandreas force-pushed the development/start-bamboo-agent-after-bamboo branch from a86cec7 to 809f4a4 Compare August 17, 2023 05:31
Copy link
Contributor

@jakubriegel jakubriegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One optional revert in the comments

docker/atlassian.yml Show resolved Hide resolved
docker/atlassian.yml Show resolved Hide resolved
@github-actions
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

Copy link
Contributor

@dearjasmina dearjasmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, works as expected: The build agent container now waits for bamboo to start.

@DominikRemo DominikRemo self-requested a review September 20, 2023 12:38
Copy link
Contributor

@DominikRemo DominikRemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as expected 👍

@b-fein b-fein added this to the 6.5.2 milestone Sep 21, 2023
@krusche krusche changed the title General: Start bamboo-build-agent after bamboo container is healthy in development setup Development: Start bamboo-build-agent after bamboo container is healthy in development setup Sep 22, 2023
@krusche krusche merged commit c87afbb into develop Sep 22, 2023
14 checks passed
@krusche krusche deleted the development/start-bamboo-agent-after-bamboo branch September 22, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants