-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Enable parallel server test execution
#6796
Conversation
Development
: Enable parallel Unit TestingDevelopment
: Enable parallel Testing
Development
: Enable parallel TestingDevelopment
: Enable parallel test execution
Note: Since this change affects the test execution order, some tests might fail. I commit this for asserting that the tests actually run (fail) faster with parallel execution enabled on bamboo and github actions. The tests will be fixed in another commit
src/main/java/de/tum/in/www1/artemis/service/scheduled/NotificationScheduleService.java
Outdated
Show resolved
Hide resolved
…-testing' into development/enable-parallel-unit-testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm, tests are much faster now 🚀 thanks for implemeting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! The tests are indeed a lot faster now 🚀
The code looks good, but I have one question:
src/test/java/de/tum/in/www1/artemis/notification/NotificationResourceIntegrationTest.java
Show resolved
Hide resolved
b8b389d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for considering my comment. Hopefully, this gets merged asap 👍
e042540
Development
: Enable parallel test executionDevelopment
: Enable parallel server test execution
Checklist
General
Server
Motivation and Context
Fast tests 🏎️
Improves server-test execution time from up to 30 min 🚗 => down to 12 min 🏎️
Description
Enables parallel testing with JUnit 5 JUnit Docs: 2.20. Parallel Execution.
Implements a new JUnit 5 extension and custom Logback appender for logging in parallel tests.
Fixes several flaky tests (e.g.: in classes LongFeedbackResourceIntegrationTest, NotificationScheduleServiceTest and ProgrammingExerciseScheduleServiceTest)
Re-organized tests into different groups for better balancing.
We used a custom plan that only executes the server tests. Besides only running the server tests, the Server Tests Only plan is similar to the Artemis Test plan
Steps for Testing
Test changes only
Review Progress
Code Review