-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add postgres docker compose setup
#6759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍🏻
Both local and dev set up work on my machine 👍🏻
I think merge should be synchronised with #6443. Artemis was much slower than on MySQL for me, but that my be connected to arm vs x64 container.
@jakubriegel What do you mean with "synchronized"? There shouldn't be any conflicts between the two PRs. |
Just to make sure that this change also supports arm. It is does, then nothing more to be done here |
@jakubriegel @TheZoker can you please re-approve if my commit to fix the merge conflicts looks good? |
Fixed the merge conflicts again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the code again and it still looks good to me 🚀
Co-authored-by: Benedikt Fein <[email protected]>
Fixed the merge conflicts again. |
Development
: Add Postgres Docker Compose SetupDevelopment
: Add postgres docker compose setup
Checklist
General
Motivation and Context
As we want to move towards Postgres, we already implemented a Docker container. We also add support for Docker Compose Setups to enable developers to try Postgres with Artemis quickly.
Description
We streamlined the official naming of PostgreSQL to Postgres as this informal naming is used in the rest of the project, apparently.
We streamlined the common cypress configurations into a common .env file.
We added Artemis Docker Compose Setups for Postgres and updated the Docs.
Therefore we introduced a new Docker Compose section in the administrator section of the Docs.
Steps for Testing
Artemis Postgres Prod Setup
docker compose -f docker/artemis-prod-postgres.yml up
docker compose -f docker/artemis-prod-postgres.yml down
and optionally delete the contents of./docker/.docker-data/artemis-postgres-data
Artemis Postgres Dev Setup
docker compose -f docker/artemis-dev-postgres.yml up
docker compose -f docker/artemis-dev-postgres.yml down -v
Check that the other Docker Compose setups you are using still work.
Review Progress
Code Review
Manual Tests