Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add postgres docker compose setup #6759

Merged
merged 23 commits into from
Sep 14, 2023

Conversation

4ludwig4
Copy link
Contributor

@4ludwig4 4ludwig4 commented Jun 23, 2023

Checklist

General

Motivation and Context

As we want to move towards Postgres, we already implemented a Docker container. We also add support for Docker Compose Setups to enable developers to try Postgres with Artemis quickly.

Description

We streamlined the official naming of PostgreSQL to Postgres as this informal naming is used in the rest of the project, apparently.
We streamlined the common cypress configurations into a common .env file.
We added Artemis Docker Compose Setups for Postgres and updated the Docs.
Therefore we introduced a new Docker Compose section in the administrator section of the Docs.

Steps for Testing

Artemis Postgres Prod Setup

  1. change the permissions in your repository according to the administrator documentation for the prod setup
  2. run the Artemis Postgres Prod Setup: docker compose -f docker/artemis-prod-postgres.yml up
  3. check Artemis
  4. shutdown Artemis Postgres Prod Setup: docker compose -f docker/artemis-prod-postgres.yml down and optionally delete the contents of ./docker/.docker-data/artemis-postgres-data

Artemis Postgres Dev Setup

  1. run the Artemis Postgres Dev Setup: docker compose -f docker/artemis-dev-postgres.yml up
  2. check Artemis
  3. shutdown and delete the volumes of Artemis Postgres Prod Setup: docker compose -f docker/artemis-dev-postgres.yml down -v

Check that the other Docker Compose setups you are using still work.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@4ludwig4 4ludwig4 marked this pull request as ready for review June 23, 2023 15:03
@4ludwig4 4ludwig4 requested a review from a team as a code owner June 23, 2023 15:03
TheZoker
TheZoker previously approved these changes Jun 30, 2023
Copy link
Contributor

@TheZoker TheZoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

jakubriegel
jakubriegel previously approved these changes Jul 2, 2023
Copy link
Contributor

@jakubriegel jakubriegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍🏻
Both local and dev set up work on my machine 👍🏻

I think merge should be synchronised with #6443. Artemis was much slower than on MySQL for me, but that my be connected to arm vs x64 container.

TheZoker
TheZoker previously approved these changes Jul 6, 2023
@4ludwig4
Copy link
Contributor Author

4ludwig4 commented Jul 7, 2023

I think merge should be synchronised with #6443.

@jakubriegel What do you mean with "synchronized"? There shouldn't be any conflicts between the two PRs.

@jakubriegel
Copy link
Contributor

I think merge should be synchronised with #6443.

@jakubriegel What do you mean with "synchronized"? There shouldn't be any conflicts between the two PRs.

Just to make sure that this change also supports arm. It is does, then nothing more to be done here

@4ludwig4 4ludwig4 dismissed stale reviews from TheZoker and jakubriegel via 475489f July 12, 2023 08:18
@4ludwig4
Copy link
Contributor Author

@jakubriegel @TheZoker can you please re-approve if my commit to fix the merge conflicts looks good?

@4ludwig4
Copy link
Contributor Author

Fixed the merge conflicts again.

b-fein
b-fein previously approved these changes Sep 1, 2023
.bamboo/E2E-tests/execute.sh Outdated Show resolved Hide resolved
Hialus
Hialus previously approved these changes Sep 1, 2023
Copy link
Member

@Hialus Hialus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the code again and it still looks good to me 🚀

@4ludwig4 4ludwig4 dismissed stale reviews from Hialus and b-fein via e50d6f0 September 2, 2023 21:07
@4ludwig4 4ludwig4 requested review from Hialus and b-fein September 2, 2023 21:08
b-fein
b-fein previously approved these changes Sep 2, 2023
Hialus
Hialus previously approved these changes Sep 2, 2023
@4ludwig4 4ludwig4 dismissed stale reviews from Hialus and b-fein via 6179f77 September 10, 2023 09:48
@4ludwig4
Copy link
Contributor Author

Fixed the merge conflicts again.

@4ludwig4 4ludwig4 requested review from Hialus, b-fein and a team September 10, 2023 09:50
@Mtze Mtze added maintainer-approved The feature maintainer has approved the PR and removed ready for review labels Sep 12, 2023
@b-fein b-fein added this to the 6.5.0 milestone Sep 12, 2023
@krusche krusche changed the title Development: Add Postgres Docker Compose Setup Development: Add postgres docker compose setup Sep 14, 2023
@krusche krusche merged commit 9e8bd09 into develop Sep 14, 2023
26 of 29 checks passed
@krusche krusche deleted the feature/docker/postgresql-setups branch September 14, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants