Communication: Change posting deletion logic to not abort when deconstructing a post

src/main/webapp/app/shared/metis/posting.directive.ts

@@ -49,6 +49,7 @@
     ngOnDestroy(): void {
         if (this.deleteTimer !== undefined) {
             clearTimeout(this.deleteTimer);
+            this.deletePostingWithoutTimeout();
         }
 
         if (this.deleteInterval !== undefined) {
@@ -72,11 +73,7 @@
 
             this.deleteTimer = setTimeout(
                 () => {
-                    if (this.isAnswerPost) {
-                        this.metisService.deleteAnswerPost(this.posting);
-                    } else {
-                        this.metisService.deletePost(this.posting);
-                    }
+                    this.deletePostingWithoutTimeout();
                 },
                 // We add a tiny buffer to make it possible for the user to react a bit longer than the ui displays (+1000)
                 this.deleteTimerInSeconds * 1000 + 1000,
@@ -139,12 +136,17 @@
         }
     }
 
+    private deletePostingWithoutTimeout() {
+        if (this.isAnswerPost) {
+            this.metisService.deleteAnswerPost(this.posting);
+        } else {
+            this.metisService.deletePost(this.posting);
     /**
      * Create a or navigate to one-to-one chat with the referenced user
      *
      * @param referencedUserLogin login of the referenced user
      */
     onUserReferenceClicked(referencedUserLogin: string) {
         const course = this.metisService.course;
         if (isMessagingEnabled(course)) {
             if (this.isCommunicationPage) {
@@ -164,7 +166,7 @@
     /**
      * Create a or navigate to one-to-one chat with the referenced user
      */
     onUserNameClicked() {
         if (!this.posting.author?.id) {
             return;
         }
@@ -187,3 +189,3 @@
         }
     }
 }