Development: Improve error logs when unresponsive build containers ca…

…nnot be stopped
ls1intum · Nov 29, 2024 · f1caa8a · f1caa8a
1 parent ca1beca
commit f1caa8a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/main/java/de/tum/cit/aet/artemis/buildagent/service/BuildJobContainerService.java b/src/main/java/de/tum/cit/aet/artemis/buildagent/service/BuildJobContainerService.java
@@ -221,10 +221,10 @@ public void stopUnresponsiveContainer(String containerId) {
             future.get(10, TimeUnit.SECONDS);  // Wait for the stop command to complete with a timeout
         }
         catch (NotFoundException | NotModifiedException e) {
-            log.debug("Container with id {} is already stopped: {}", containerId, e.getMessage());
+            log.warn("Container with id {} is already stopped.", containerId, e);
         }
         catch (Exception e) {
-            log.warn("Failed to stop container with id {}. Attempting to kill container: {}", containerId, e.getMessage());
+            log.error("Failed to stop container with id {}. Attempting to kill container.", containerId, e);
 
             // Attempt to kill the container if stop fails
             try {
@@ -236,7 +236,7 @@ public void stopUnresponsiveContainer(String containerId) {
                 killFuture.get(5, TimeUnit.SECONDS);  // Wait for the kill command to complete with a timeout
             }
             catch (Exception killException) {
-                log.warn("Failed to kill container with id {}: {}", containerId, killException.getMessage());
+                log.error("Failed to kill container with id {}.", containerId, killException);
             }
         }
         finally {