On review

ls1intum · Oct 11, 2023 · bddf9b2 · bddf9b2
1 parent 5bf4860
commit bddf9b2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/...cript/spec/component/overview/course-conversations/course-conversations.component.spec.ts b/...cript/spec/component/overview/course-conversations/course-conversations.component.spec.ts
@@ -172,10 +172,10 @@ examples.forEach((activeConversation) => {
         });
 
         it('should accept code of conduct', () => {
-            const spy = jest.spyOn(component.metisConversationService, 'acceptCodeOfConduct');
-            component.ngOnInit();
+            const metisSpy = jest.spyOn(metisConversationService, 'acceptCodeOfConduct');
+            fixture.detectChanges();
             component.acceptCodeOfConduct();
-            expect(spy).toHaveBeenCalledOnce();
+            expect(metisSpy).toHaveBeenCalledOnce();
         });
     });
 });
diff --git a/...ns/layout/conversation-selection-sidebar/conversation-selection-sidebar.component.spec.ts b/...ns/layout/conversation-selection-sidebar/conversation-selection-sidebar.component.spec.ts
@@ -290,7 +290,7 @@ examples.forEach((activeConversation) => {
             }));
 
             it('should open code of conduct', () => {
-                const metisSpy = jest.spyOn(component.metisConversationService, 'setCodeOfConduct');
+                const metisSpy = jest.spyOn(metisConversationService, 'setCodeOfConduct');
                 component.openCodeOfConduct();
                 expect(metisSpy).toHaveBeenCalledOnce();
             });

diff --git a/src/test/javascript/spec/helpers/mocks/service/mock-course-management.service.ts b/src/test/javascript/spec/helpers/mocks/service/mock-course-management.service.ts
@@ -4,8 +4,7 @@ import { Course, CourseGroup } from 'app/entities/course.model';
 import { TextExercise } from 'app/entities/text-exercise.model';
 import { Exercise } from 'app/entities/exercise.model';
 import { User } from '@sentry/angular-ivy';
-import { EntityArrayResponseType, RoleGroup } from 'app/course/manage/course-management.service';
-import { UserPublicInfoDTO } from 'app/core/user/user.model';
+import { EntityArrayResponseType } from 'app/course/manage/course-management.service';
 
 export class MockCourseManagementService {
     mockExercises: Exercise[] = [new TextExercise(undefined, undefined)];
@@ -42,8 +41,4 @@ export class MockCourseManagementService {
     getAll(): Observable<EntityArrayResponseType> {
         return of(new HttpResponse({ body: [] }));
     }
-
-    searchUsers(courseId: number, loginOrName: string, roles: RoleGroup[]): Observable<HttpResponse<UserPublicInfoDTO[]>> {
-        return of(new HttpResponse({ body: [] }));
-    }
 }