Skip to content

Commit

Permalink
Revert "Add missing branch attribute to programming-exercise.model.ts"
Browse files Browse the repository at this point in the history
This reverts commit e93b317.
  • Loading branch information
julian-christl committed Sep 13, 2023
1 parent 0794d2b commit 85ce04c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,6 @@ private void checkProgrammingExerciseForError(ProgrammingExercise exercise) {
ProgrammingExerciseResourceErrorKeys.INVALID_TEST_CASE_WEIGHTS);
}
}

if (exercise.getBranch() == null) {
// TODO: only activate this after the migration where all branches are set properly
log.warn("Branch of programming exercise {} is not specified.", exercise.getId());
// throw new BadRequestAlertException("The branch of the programming exercise must be set.", "Exercise",
// ProgrammingExerciseResourceErrorKeys.INVALID_BRANCH);
}
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ public final class ProgrammingExerciseResourceErrorKeys {

public static final String INVALID_AUXILIARY_REPOSITORY_DESCRIPTION = "invalid.auxiliary.repository.description";

public static final String INVALID_BRANCH = "invalid.branch.description";

public static final String INVALID_TEST_CASE_WEIGHTS = "invalid.testcases.weights";

private ProgrammingExerciseResourceErrorKeys() {
Expand Down
1 change: 0 additions & 1 deletion src/main/webapp/app/entities/programming-exercise.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ export class ProgrammingExercise extends Exercise {
public testCasesChanged?: boolean;

public projectType?: ProjectType;
public branch?: string;

public testwiseCoverageEnabled?: boolean;

Expand Down

0 comments on commit 85ce04c

Please sign in to comment.