Development: Remove race condition in faky playwright test (#10013)

ls1intum · Dec 16, 2024 · 5449cc4 · 5449cc4
1 parent 64a0d1e
commit 5449cc4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/test/playwright/e2e/course/CourseMessages.spec.ts b/src/test/playwright/e2e/course/CourseMessages.spec.ts
@@ -142,11 +142,12 @@ test.describe('Course messages', { tag: '@fast' }, () => {
                 await login(instructor, `/courses/${course.id}/communication?conversationId=${channel.id}`);
                 const newName = 'new-test-name';
                 const topic = 'test-topic';
-                await courseMessages.getName().click();
+
+                // each edit action triggers an update to the server, on multinode this can lead to a race condition
                 await courseMessages.editName(newName);
                 await courseMessages.editTopic(topic);
                 await courseMessages.editDescription('New Description');
-                await courseMessages.closeEditPanel();
+
                 await page.reload();
                 await page.locator('jhi-conversation-header').waitFor({ state: 'visible', timeout: 10000 });
                 await expect(courseMessages.getName()).toContainText(newName);

diff --git a/src/test/playwright/support/pageobjects/course/CourseMessagesPage.ts b/src/test/playwright/support/pageobjects/course/CourseMessagesPage.ts
@@ -170,35 +170,47 @@ export class CourseMessagesPage {
      * @param newName - The new name for the conversation.
      */
     async editName(newName: string) {
+        await this.getName().click();
         await this.page.locator('#name-section .action-button').click();
         const nameField = this.page.locator('.channels-overview #name');
         await nameField.clear();
         await nameField.fill(newName);
         await this.page.locator('#submitButton').click();
+        await expect(this.page.locator('#name-section textarea')).toHaveValue(newName);
+        await this.closeEditPanel();
+        await this.page.waitForTimeout(200);
     }
 
     /**
      * Edits the topic of the conversation to a new topic.
      * @param newTopic - The new topic for the conversation.
      */
     async editTopic(newTopic: string) {
+        await this.getName().click();
         await this.page.locator('#topic-section .action-button').click();
         const topicField = this.page.locator('.channels-overview #topic');
         await topicField.clear();
         await topicField.fill(newTopic);
         await this.page.locator('#submitButton').click();
+        await expect(this.page.locator('#topic-section textarea')).toHaveValue(newTopic);
+        await this.closeEditPanel();
+        await this.page.waitForTimeout(200);
     }
 
     /**
      * Edits the description of the conversation to a new description.
      * @param newDescription - The new description for the conversation.
      */
     async editDescription(newDescription: string) {
+        await this.getName().click();
         await this.page.locator('#description-section .action-button').click();
         const descriptionField = this.page.locator('.channels-overview #description');
         await descriptionField.clear();
         await descriptionField.fill(newDescription);
         await this.page.locator('#submitButton').click();
+        await expect(this.page.locator('#description-section textarea')).toHaveValue(newDescription);
+        await this.closeEditPanel();
+        await this.page.waitForTimeout(200);
     }
 
     /**