Communication: Fix scrolling error for long messages (#9997)

ls1intum · Dec 14, 2024 · 0c8eefe · 0c8eefe
1 parent fafe68c
commit 0c8eefe
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/...view/course-conversations/layout/conversation-messages/conversation-messages.component.ts b/...view/course-conversations/layout/conversation-messages/conversation-messages.component.ts
@@ -441,7 +441,7 @@ export class ConversationMessagesComponent implements OnInit, AfterViewInit, OnD
             }
         }
         this.elementsAtScrollPosition = visibleMessages;
-        if (this.elementsAtScrollPosition && this.canStartSaving) {
+        if (this.elementsAtScrollPosition && this.elementsAtScrollPosition.length > 0 && this.canStartSaving) {
             this.saveScrollPosition(this.elementsAtScrollPosition[0].post.id!);
         }
     }

diff --git a/...course-conversations/layout/conversation-messages/conversation-messages.component.spec.ts b/...course-conversations/layout/conversation-messages/conversation-messages.component.spec.ts
@@ -284,5 +284,14 @@ examples.forEach((activeConversation) => {
                 expect(inlineInput).toBeTruthy(); // Check if the inline input component is present
             }));
         }
+
+        it('should scroll to bottom and set canStartSaving to true when lastScrollPosition is falsy', async () => {
+            const scrollToBottomSpy = jest.spyOn(component, 'scrollToBottomOfMessages');
+
+            await component.goToLastSelectedElement(0, false);
+
+            expect(scrollToBottomSpy).toHaveBeenCalledOnce();
+            expect(component.canStartSaving).toBeTrue();
+        });
     });
 });