Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honor timeout set for REST API calls #345

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Conversation

ludomikula
Copy link
Collaborator

Proposed changes

Honor query timeout when call REST API endpoints. Fixes #332

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

@netlify
Copy link

netlify bot commented Aug 20, 2023

Deploy Preview for lowcoder-cloud canceled.

Name Link
🔨 Latest commit 6025a80
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-cloud/deploys/64e206fe7da12d00082963ee

FalkWolsky
FalkWolsky previously approved these changes Aug 20, 2023
Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this important contribution!

Copy link
Contributor

@FalkWolsky FalkWolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this Setting!

@FalkWolsky FalkWolsky merged commit 0784aba into main Aug 20, 2023
6 checks passed
@FalkWolsky FalkWolsky deleted the rest_api_timeout branch August 20, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Query - "Timeout After" value not utilized.
2 participants