Rework Vivado optimisations for wide compatibility #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotb-lowrisc
force-pushed
the
rm-hook
branch
from
5a55667
to
99080e7
Compare
|
Rebase and add update of CI timing report path |
Turns out that Vivado 2024.1 rearranges its implementation script so that reporting is done before the post-route hook is called. This made it seem as though builds were failing timing, even when the post-route hook optimisations had fixed them. Exploration revealed that Vivado has an optional post-route optimisation stage that can be enabled and tweaked via TCL scripts. This includes updated reporting and such. So, rework the post-route optimisation to use Vivado's stage rather than a custom hook. This required putting the optimisation level in vivado_setup.tcl rather than in one of the hooks, which meant that all the optimisation level decision making also had to move to the same. This should be effectively a no-op except for reporting.
marnovandermaas
force-pushed
the
rm-hook
branch
from
99080e7
to
eea73ba
Compare
|
Rebasing on top of v1.0 release. |
marnovandermaas
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that Vivado 2024.1 rearranges its implementation script so that reporting is done before the post-route hook is called. This made it seem as though builds were failing timing, even when the post-route hook optimisations had fixed them.
Exploration revealed that Vivado has an optional post-route optimisation stage that can be enabled and tweaked via TCL scripts. This includes updated reporting and such.
So, rework the post-route optimisation to use Vivado's stage rather than a custom hook.
This required putting the optimisation level in vivado_setup.tcl rather than in one of the hooks, which meant that all the optimisation level decision making also had to move to the same.
This should be effectively a no-op except for reporting.
Not to be merged before 1.0 release.