Added clang-tidy lint to checks #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HU90m
force-pushed
the
lints
branch
3 times, most recently
from
6c2a9fe
to
ec7ca80
Compare
The clang-tidy check requires dependancies to be pulled in.
Merged
nbdd0121
reviewed
Jun 8, 2024
Comment on lines
+72
to
+75
| apps.clang-lint = { | ||
| type = "app"; | ||
| program = getExe clang-lint; | ||
| }; |
There was a problem hiding this comment.
Perhaps this part could be added to formatter. You can change it to a script calling both alejandra and clang-lint
There was a problem hiding this comment.
That's a cool idea. I noticed clang-tidy -fix did make changes that broke code and is a little slower than your average formatter. We could just put clang-format and alejandra together as the formatter, but it is quite neat having clang-tidy and clang-format called from the same script.
nbdd0121
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can now run: