Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prox sensor #15

Merged
merged 2 commits into from
May 30, 2024
Merged

Prox sensor #15

merged 2 commits into from
May 30, 2024

Conversation

GregAC
Copy link
Contributor

@GregAC GregAC commented May 29, 2024

No description provided.

@GregAC
Copy link
Contributor Author

GregAC commented May 29, 2024

Recreated version of #14 as some bit of github infrastructure fell over so CI wasn't running and merging wasn't possible.

@GregAC
Copy link
Contributor Author

GregAC commented May 29, 2024

Bypassing CI, checked and fixed locally and it's not getting a runner.

@GregAC
Copy link
Contributor Author

GregAC commented May 29, 2024

Unfortunately github is refusing to merge 'Merge attempt failed'

So will leave it for now try again tomorrow!

@nbdd0121
Copy link
Contributor

Change runs-on in .github/workflows/ci.yml from 23.11 to 24.05 should fix the issue. I fixed the sonata-system repo but forgot to change this repo.

@GregAC
Copy link
Contributor Author

GregAC commented May 30, 2024

Merging on the basis of the previous review (#14)

@GregAC GregAC merged commit 22feb94 into lowRISC:main May 30, 2024
1 check passed
@GregAC GregAC deleted the prox_sensor branch May 30, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants