Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce LCD drivers and example program #11

Merged
merged 2 commits into from
May 27, 2024
Merged

Introduce LCD drivers and example program #11

merged 2 commits into from
May 27, 2024

Conversation

nbdd0121
Copy link
Contributor

No description provided.

@nbdd0121 nbdd0121 requested a review from HU90m May 27, 2024 15:59
@nbdd0121 nbdd0121 mentioned this pull request May 27, 2024
Merged
@HU90m
Copy link
Member

HU90m commented May 27, 2024 •
edited
Loading

Did you forget include display_drivers/core/m3x6_16pt.h?

Sorry, missed that this was a submodule

HU90m
HU90m approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@HU90m HU90m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it works wonderfully!

It doesn't pass CHERIoT's clang-tidy style checks, but that's not setup and so not important/enforced for the sonata-software repo at the moment

library/lcd.hh Outdated Show resolved Hide resolved
library/lcd.hh Outdated Show resolved Hide resolved
library/lcd.hh Outdated Show resolved Hide resolved
@nbdd0121 nbdd0121 merged commit d8ba1e1 into lowRISC:main May 27, 2024
1 check passed
@nbdd0121 nbdd0121 deleted the lcd branch May 27, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HU90m HU90m HU90m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbdd0121 @HU90m