feat: dockge set/update agent friendly name #414
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,12 +76,15 @@ export class AgentManager { | |
| * @param url | ||
| * @param username | ||
| * @param password | ||
| * @param friendlyname | ||
| * @param updatedFriendlyName | ||
| */ | ||
| async add(url : string, username : string, password : string, friendlyname : string) : Promise<Agent> { | ||
| let bean = R.dispense("agent") as Agent; | ||
| bean.url = url; | ||
| bean.username = username; | ||
| bean.password = password; | ||
| bean.friendlyname = friendlyname; | ||
| await R.store(bean); | ||
| return bean; | ||
| } | ||
|
|
@@ -104,6 +107,16 @@ export class AgentManager { | |
| } | ||
| } | ||
|
|
||
| /** | ||
| * | ||
| * @param friendlyname | ||
| * @param updatedFriendlyName | ||
| */ | ||
|
|
||
| async update(friendlyname : string, updatedFriendlyName : string) { | ||
|
There was a problem hiding this comment. I would consider accepting the agent's ID is the primary key, so thats probably best to use for updating the agent. But URL is always set and has a unique constraint, so it will work too. There was a problem hiding this comment. I agree with nathan, I would refactor to pass id around for the agent There was a problem hiding this comment. sure it should be the |
||
| await R.exec("UPDATE agent SET friendlyname = " + updatedFriendlyName + " WHERE friendlyname = " + friendlyname + ""); | ||
|
There was a problem hiding this comment. SQL injection vuln here - if name has quotes this will break. You can use parameter bindings to build queries safely: await R.exec("UPDATE agent SET friendlyname = ? WHERE friendlyname = ?", [
updatedFriendlyName,
friendlyname
]);https://github.com/louislam/redbean-node/blob/master/docs/Query.md There was a problem hiding this comment. Instead of a raw query, you could utilize the redbean ORM methods. See: https://github.com/louislam/redbean-node/blob/master/docs/Create-Update-Bean.md Something like this if by ID (primary key): const agent = await R.load('agent', id);
agent.friendlyName = friendlyName;
await R.store(agent);Or by URL: const agent = await R.findOne('agent', ' url = ? ', [url]);
agent.friendlyName = friendlyName;
await R.store(agent);There was a problem hiding this comment. Thanks for the input. Added this with |
||
| } | ||
|
|
||
| connect(url : string, username : string, password : string) { | ||
| let obj = new URL(url); | ||
| let endpoint = obj.host; | ||
|
|
@@ -276,6 +289,8 @@ export class AgentManager { | |
| url: "", | ||
| username: "", | ||
| endpoint: "", | ||
| friendlyname: "", | ||
| updatedFriendlyName: "", | ||
| }; | ||
|
|
||
| for (let endpoint in list) { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ export async function up(knex: Knex): Promise<void> { | |
| table.string("url", 255).notNullable().unique(); | ||
| table.string("username", 255).notNullable(); | ||
| table.string("password", 255).notNullable(); | ||
| table.string("friendlyname", 255); | ||
|
There was a problem hiding this comment. This file cannot be modified. Have to create a new file. Migration guide: Also the naming convention, it should be Will come back later, as I would like to finish the next milestone of Uptime Kuma first. |
||
| table.boolean("active").notNullable().defaultTo(true); | ||
| }); | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name Conventions
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md#name-conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all namings has been updated