Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interprets $TOKEN to it's .env file value for port parsing #246

Closed
wants to merge 2 commits into from

Conversation

syko9000
Copy link
Contributor

@syko9000 syko9000 commented Dec 5, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

When a port uses a template variable, "$PORT:8080", specified in the .env file. Currently the port link on the container view shows "$PORT" and is not clickable. This fix parses out the $TOKEN's and replaces them with the value in the .env file before creating the URL link. Also, if not present the default value specified inline, example ${PORT:-8080}, "8080" would replace the token if PORT is not specified. Handles .env file vars in double or single quotes and unescapes any in the string if needed.

The interpreter will handle any values, not just ports, but only used for ports at this point.

It does not handle nested tokens, example ${PORT:-${DEFAULT_PORT}}

Fixes #237

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@louislam
Copy link
Owner

louislam commented Dec 6, 2023

Unfortunately, I am working on this too, and the issue is actually more than just port numbers, because template variables could be everywhere in a yaml file.

Also there are existing dependencies that can parse and render environment variables into a file. I will show you later in a new pull request.

@syko9000
Copy link
Contributor Author

syko9000 commented Dec 6, 2023

No worries

@syko9000 syko9000 closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Displayed open port get from .env
2 participants