Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'stackName' param to return value #206

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

ThalesC
Copy link
Contributor

@ThalesC ThalesC commented Nov 28, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Maybe a mishap, but this was causing issues with opening the correct terminals for each container.

If containers from different stacks had the same service name (e.g. stack1-server and stack2-server), the frontend would bind a terminal based only on the service name and not open the correct one.

Steps to reproduce:

  1. Deploy two or more stacks with the same service names, like:

stack1

version: "3.8"
services:
  server:
    image: ...
...

stack2

version: "3.8"
services:
  server:
    image: ...
...
  1. Select one of the stacks (stack1)
  2. Click to open the container's terminal from this stack (stack1-server)
  3. Select the other stack (stack2)
  4. Click to open the other terminal (should be stack2-server, but will be stack1-server)

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Maybe a mishap, but this was causing issues with opening the correct terminals for each container
@louislam
Copy link
Owner

Good catch!

@louislam louislam merged commit 71446b9 into louislam:master Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants