Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes keyboard navigation include items in optgroups #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Frique
Copy link
Contributor

@Frique Frique commented Aug 19, 2013

Navigating by up and down arrow works better now.

Navigating by up and down arrow works better now.
@lou
Copy link
Owner

lou commented Aug 29, 2013

Hi @Frique,
I just tested keyboard navigation with optgroups and it seems to work well for me (chrome, firefox, safari).
On which browser did you test? If on IE please provide the version number :trollface:

@Frique
Copy link
Contributor Author

Frique commented Aug 29, 2013

Hi.
I think in every browser I tested (chrome, firefox, IE 7,8,9) it fails depending on the order of items. If you have a few options, followed by an optgroup with options, the keyboard selection will keep cycling above the optgroup. I'll set up a fiddle if you can't reproduce.

@lou
Copy link
Owner

lou commented Aug 29, 2013

Ha I only tested when every options are surrounded by optgroups.
So I suspect I can reproduce if I make a select with options within optgroups and some without.
Thanks, I will try,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants