Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dpsgraph #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Dpsgraph #12

wants to merge 5 commits into from

Conversation

synopia
Copy link

@synopia synopia commented Mar 25, 2023

New tab with a dps graph like seen at lailai. Can be disabled in settings.

@Henjuro
Copy link
Contributor

Henjuro commented Mar 26, 2023

Should be nice to have a dps graph but I think you need to add your setting to src-electron/util/app-settings.ts too

@Henjuro
Copy link
Contributor

Henjuro commented Mar 26, 2023

If I may ask this graph is average dps from the start of the raid to each data point not a rolling window one yes?

@Henjuro
Copy link
Contributor

Henjuro commented Mar 26, 2023

I wonder if maybe it would be better to have a rolling window graph.
Graphs are from vykas g3
Like this is 1s interval for datapoints with 10s damage avg (5s before, 5s after)
image
vs current 5s interval for datapoints with avg dps since start of raid
image

also maybe allow for zooming by adding ToolboxComponent, DataZoomComponent and

toolbox: { left: 'center', itemSize: 25, top: 55, feature: { dataZoom: { yAxisIndex: 'none' }, restore: {} } }, dataZoom: [ { type: 'inside', throttle: 50 } ],

@synopia
Copy link
Author

synopia commented Mar 26, 2023

I modified it to have a fixed number of intervals (100 for now, should be moved to settings) showing the rolling avg for 4 times the interval length. Also refactored to use the same player names functionality used in normal DMG table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants