Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy hook tests #578

Merged
merged 1 commit into from
Jul 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 0 additions & 102 deletions .github/workflows/hook-tests-legacy.yml

This file was deleted.

14 changes: 0 additions & 14 deletions vignettes/testing.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,6 @@ This package has five testing workflows:
`run_test()` and check in the user R profile if it is set, and then
activate the renv. This is done with `R_PRECOMMIT_HOOK_ENV`.

- Legacy hook testing: It is possible that someone updates the R
package {precommit}, but not the hook revision (e.g. with
`precommit::autoupdate()`) or vice versa. If the hook revision is
updated to `>= 0.2.0`, all hook scripts and {precommit} functions
called from the hook script are from the same version of
{precommit}, so we don't need to test hook compatibility. If the R
package is updated but not the hook revision, old hook scripts are
called with while the {precommit} functions in them are from a new
package version. Hence, we need compatibility between new packages
and old hook scripts, which is exactly what is tested with this
workflow. Until there are breaking changes in the *hook script
helpers* family of exported functions, there should not be a
problem.

- complete testing: Tests hooks as well as usethis like access
functionality with latest CRAN packages, on all platforms, with all
installation methods.
Expand Down
Loading